Nova support cinder client v2

Registered by Dazhao Yu on 2013-10-31

Now nova only support cinder client v1 by default, from nova/volume/cinder, it just import cinderclient.v1 as cinderclient. Since cinder have v1 and v2 client, we need implement nova support cinder v2 client function.

Nova did not support to get cinder v2 API, just like Nova did not support to get glance v2 api. Base on the ML discuss talk : http://lists.openstack.org/pipermail/openstack-dev/2013-November/020194.html, we need to use keystone service catalog to judge if use cinder v1 or v2 in nova

The blueprint also fix bug 1215772 -- Nova Attach/Detach Volume can't work if volume endpoint set to v2

    1. Who would use the feature? -- All of OpenStack nova component users.

   2. Why use the feature? --- This feature is for enable cinder v2 api in nova component, currently nova code just hard code to use cinder v1 api, it is not make sense, this blueprint provide to use keystone service catalog to choose the appropriate cinder api version, make sure nova can support cinder api version 2.

   3. What is the exact usage for the feature? For a CLI call, provide examples of all the parameters the patch includes. --- When the cinder endpoint is for version 2 in keystone, from nova component, we will use keystone service catalog to choose the cinder client, so in nova part, the called cinder client will be matched with keystone service catalog.

   4. Does the feature also have permissions/policies attached? No

Blueprint information

Status:
Complete
Approver:
John Garbutt
Priority:
High
Drafter:
Dazhao Yu
Direction:
Approved
Assignee:
Mike Perez
Definition:
Approved
Series goal:
Accepted for juno
Implementation:
Implemented
Milestone target:
milestone icon 2014.2
Started by
Dazhao Yu on 2013-10-31
Completed by
Michael Still on 2014-08-12

Related branches

Sprints

Whiteboard

Overall this BP looks straightforward, but can you update the BP to answer the following questions http://justwriteclick.com/2013/09/17/openstack-docimpact-flag-walk-through/ --jogo

Approved for I-3, we definitely want to support cinders v2 API. --jogo

Gerrit topic: https://review.openstack.org/#q,topic:bp/support-cinderclient-v2,n,z

Addressed by: https://review.openstack.org/43986
    Code change for nova support cinder client v2

We should really make this high priority, but its too late now, something for Juno-1 if we don't get this in now --johnthetubaguy

Apologies, this missed the deadline for Feature Freeze. Please rebase patches as soon as Juno opens, and we will try to get this in during that period. --johnthetubaguy (5th March 2014)
Unapproved - please re-submit via nova-spec --johnthetubagy (20th March 2014)

Addressed by: https://review.openstack.org/88480
    Code change for nova support cinder client v2

Addressed by: https://review.openstack.org/88500
    Add support for Cinder v2 API

Addressed by: https://review.openstack.org/89971
    Code change for nova support cinder client v2

Code is up for review, spec is merged, so I updated the blueprint as required by the process (milestone, url, etc), and so it is now approved --johnthetubaguy (8th May 2014)

(probably?) abandoned patches:
==========================

Addressed by: https://review.openstack.org/88480
    Code change for nova support cinder client v2

Addressed by: https://review.openstack.org/89971
    Code change for nova support cinder client v2

Merged patches:
==============

Addressed by: https://review.openstack.org/88500
    Add support for Cinder v2 API (...just the spec)

Current patches:
=============
Addressed by: https://review.openstack.org/43986
    Code change for nova support cinder client v2

Sorry, this has not got enough positive reviews to make it in time for juno-1, moving to juno-2 --johnthetubaguy 10th June 2014

Gerrit topic: https://review.openstack.org/#q,topic:bug/1215772,n,z

Reviews do not have +2s and are not close to approval, so moving to juno-3. But please move this back to juno-2, should you get your patches approved in time. --johnthetubaguy

[5-Aug-2014] Is this done now? I don't see any reviews up for this based on topic or owner...

[13 Aug 2014] Marked implemented as per IRC conversation with the author.

(?)

Work Items

Dependency tree

* Blueprints in grey have been implemented.

This blueprint contains Public information 
Everyone can see this information.