OpenStack Compute (Nova)

Remove callbacks from virt driver(s)

Registered by Brian Lamar on 2011-08-25

There are unused callback parameters in the virt driver (nova.virt.driver:ComputeDriver). Specifically:

    def pause(self, instance, callback):
    def unpause(self, instance, callback):
    def suspend(self, instance, callback):
    def resume(self, instance, callback):
    def rescue(self, context, instance, callback, network_info):
    def unrescue(self, instance, callback, network_info):

I believe the original intention was to pass a callback and then perform a non-blocking call at the virt layer...but none of the drivers support this I would like to remove them to reduce programmer confusion. XenAPI comes the closest, but it does a blocking loop before finally calling the callback...essentially making the callback useless.

Blueprint information

Status:
Complete
Approver:
Vish Ishaya
Priority:
Low
Drafter:
Brian Lamar
Direction:
Approved
Assignee:
Brian Lamar
Definition:
Approved
Series goal:
Accepted for essex
Implementation:
Implemented
Milestone target:
milestone icon 2012.1
Started by
Thierry Carrez on 2011-11-14
Completed by
Thierry Carrez on 2011-11-15

Sprints

Whiteboard

Gerrit topic: https://review.openstack.org/#q,topic:bp/remove-virt-driver-callbacks,n,z

Addressed by: https://review.openstack.org/1100
    Removed callback concept on VM driver methods:

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.