Remove mox from testing infrastructure - Newton (partial)

Registered by Matt Riedemann on 2016-03-22

This is to pick up on the work from mitaka for blueprint remove-mox:

https://blueprints.launchpad.net/nova/+spec/remove-mox

But this is for newton work.

Blueprint information

Status:
Complete
Approver:
Andrew Laski
Priority:
Low
Drafter:
Matt Riedemann
Direction:
Approved
Assignee:
None
Definition:
Approved
Series goal:
Accepted for newton
Implementation:
Implemented
Milestone target:
milestone icon newton-3
Started by
John Garbutt on 2016-03-24
Completed by
Matt Riedemann on 2016-09-01

Related branches

Sprints

Whiteboard

Gerrit topic: https://review.openstack.org/#q,topic:bp/remove-mox-newton,n,z

Addressed by: https://review.openstack.org/265476
    Stop using mox stubs in test_configdrive

Addressed by: https://review.openstack.org/270303
    remove mox from vmwareapi/test_driver_api.py

Addressed by: https://review.openstack.org/271069
    remove mox from vmwareapi/test_vif.py

Addressed by: https://review.openstack.org/298490
    Remove mox from tests/unit/api/openstack/compute/test_baremetal_nodes.py

Addressed by: https://review.openstack.org/298533
    Remove mox from tests/unit/network/test_rpcapi.py

Addressed by: https://review.openstack.org/298604
    Remove mox from tests/functional/api_sample_tests/test_cells.py

Addressed by: https://review.openstack.org/#/c/299001
    Stop using mox in test_security_groups

Addressed by: https://review.openstack.org/299134
    Remove mox from tests/unit/objects/test_migration.py

Addressed by: https://review.openstack.org/299644
    Remove mox from tests/unit/objects/test_aggregate.py

Addressed by: https://review.openstack.org/300939
    Remove mox from tests/unit/volume/test_cinder.py

Addressed by: https://review.openstack.org/301336
    [WIP] Remove mox from tests/unit/compute/test_compute_api

Addressed by: https://review.openstack.org/301381
    Remove mox from tests/unit/compute/test_compute_xen.py

Addressed by: https://review.openstack.org/302283
    Remove mox from tests/unit/network/security_group/test_neutron_driver.py

Addressed by: https://review.openstack.org/303805
    Remove mox from tests/unit/network/test_api.py

Addressed by: https://review.openstack.org/303833
    Remove mox from tests/unit/conductor/tasks/test_live_migrate.py

Addressed by https://review.openstack.org/#/c/304821
    Remove mox from tests/unit/virt/test_imagecache.py

Gerrit topic: https://review.openstack.org/#q,topic:301336,n,z

Addressed by: https://review.openstack.org/304892
    Remove mox from test_extensions.py

Addressed by: https://review.openstack.org/304821
    Remove mox from tests/unit/virt/test_imagecache.py

Addressed by: https://review.openstack.org/306536/
    Stop using mox in test_firewall

Addressed by: https://review.openstack.org/306597
    Not using mox stubs in nova.tests.unit.volume

Addressed by: https://review.openstack.org/306611
    Not using mox stubs in nova.tests.unit.consoleauth

Addressed by: https://review.openstack.org/306232
    Remove mox used in test_server_start_stop

Addressed by: https://review.openstack.org/307126
    Remove mox in tests/unit/objects/test_instance_faults

Addressed by: https://review.openstack.org/307135
    Remove mox in tests/unit/objects/test_security_group

Addressed by: https://review.openstack.org/307141
    Remove mox in tests/unit/objects/test_quotas

Addressed by: https://review.openstack.org/307155
    Remove mox in tests/unit/objects/test_instance_info_cache

Addressed by : https://review.openstack.org/306536
    Stop using mox in test_firewall

Addressed by: https://review.openstack.org/307615
    Remove mox in tests/unit/objects/test_pci_device

Addressed by: https://review.openstack.org/307625
    Remove mox in tests/unit/objects/test_compute_node

Addressed by: https://review.openstack.org/308021
    Remove mox from compute/test_compute_cells.py

Addressed by: https://review.openstack.org/308120
    Remove mox from unit/api/openstack/compute/test_block_device_mapping.py

Addressed by: https://review.openstack.org/308155
    Stop using mox stubs in test_admin_password.py

Addressed by: https://review.openstack.org/308158
    Stop using mox stubs in test_access_ips.py

Addressed by: https://review.openstack.org/308170
    Stop using mox stubs in test_admin_actions.py

Addressed by: https://review.openstack.org/308213
    Remove mox in tests/unit/compute/test_host_api.py

Addressed by: https://review.openstack.org/308244
    Remove mox in test_certificates.py

Addressed by: https://review.openstack.org/308746
    Remove mox in test_block_device_mapping_v1.py

Addressed by: https://review.openstack.org/308762
    Stop using mox stubs in test_multinic.py

Addressed by: https://review.openstack.org/308806
    Stop using mox stubs in test_pipelib.py

Addressed by: https://review.openstack.org/309737
    Stop using mox stubs in test_createserverext.py

Addressed by: https://review.openstack.org/309738
    Stop using mox stubs in test_disk_config.py

Addressed by: https://review.openstack.org/311288
    Remove mox in nova/tests/unit/objects/test_pci_device.py

Addressed by: https://review.openstack.org/306385
    not use mox for conductor/test_conductor.py

Addressed by: https://review.openstack.org/312519
    Remove mox from tests/unit/conductor/tasks/test_live_migrate.py(2)

Addressed by: https://review.openstack.org/312529
    Remove mox from tests/unit/conductor/tasks/test_live_migrate.py(3)

Addressed by: https://review.openstack.org/312589
    Remove mox from tests/unit/conductor/tasks/test_live_migrate.py(4)

Addressed by: https://review.openstack.org/312858
    Remove mox from test_instance_fault.py

Addressed by: https://review.openstack.org/313219
    Remove mox in unit/virt/xenapi/test_agent.py

Addressed by: https://review.openstack.org/315309
    Remove mox in test_volume_snapshot_create_outer_success

Addressed by: https://review.openstack.org/316427
    Remove mox in network/test_linux_net.py

Addressed by: https://review.openstack.org/319736
    Stop using mox stubs in volume/encryptors/test_base.py

Addressed by: https://review.openstack.org/320325
    Remove mox stubs in api/openstack/compute/test_virtual_interfaces.py

Addressed by: https://review.openstack.org/320346
    Remove mox from api/openstack/compute/test_deferred_delete.py

Addressed by: https://review.openstack.org/320392
    Remove mox from unit/api/openstack/compute/test_migrations.py

Addressed by: https://review.openstack.org/320821
    Remove mox from unit/api/openstack/compute/test_serversV21.py

Addressed by: https://review.openstack.org/320826
    Remove mox stubs in api/openstack/compute/test_server_reset_state.py

Addressed by: https://review.openstack.org/321326
    Stop using mox stubs in test_shelve.py

Addressed by: https://review.openstack.org/321341
    Stop using mox stubs in test_instance_actions.py

Addressed by: https://review.openstack.org/321345
    Stop using mox stubs in test_evacuate.py

Addressed by: https://review.openstack.org/321351
    Remove mox from unit/api/openstack/compute/test_aggregates.py

Addressed by: https://review.openstack.org/321385
    Remove mox from api/openstack/compute/test_availability_zone.py

Addressed by: https://review.openstack.org/321420
    Remove mox from unit/api/openstack/compute/test_cloudpipe.py

Addressed by: https://review.openstack.org/321428
    Remove mox from api/openstack/compute/test_config_drive.py

Addressed by: https://review.openstack.org/321435
    Remove mox from api/openstack/compute/test_console_auth_tokens.py

Addressed by: https://review.openstack.org/321439
    Remomve mox from api/openstack/compute/test_console_output.py

Addressed by: https://review.openstack.org/#/c/321467/
    Remove mox from unit/virt/libvirt/volume/test_volume.py
    Remove mox from unit/virt/libvirt/volume/test_nfs.py
    Remove mox from unit/virt/libvirt/volume/test_glusterfs.py

Addressed by: https://review.openstack.org/321469
    Remove mox from api/openstack/compute/test_extended_hypervisors.py

Addressed by: https://review.openstack.org/321932
    Stop using mox stubs in test_snapshots.py

Addressed by: https://review.openstack.org/321944
    Remove mox from api/openstack/compute/test_extended_ips.py

Addressed by: https://review.openstack.org/321952
    Remove mox from test_extended_server_attributes.py

Addressed by: https://review.openstack.org/321954
    Remove mox from compute/test_extended_ips_mac.py

Addressed by: https://review.openstack.org/321959
    Remove mox from unit/virt/xenapi/image/test_bittorrent.py

Addressed by: https://review.openstack.org/321962
    Remove mox from api/openstack/compute/test_consoles.py

Addressed by: https://review.openstack.org/321966
    Remove mox from api/openstack/compute/test_extended_status.py

Addressed by: https://review.openstack.org/321994
    Stop using mox stubs in test_flavor_disabled.py

Addressed by: https://review.openstack.org/322003
    Stop using mox stubs in test_attach_interfaces.py

Addressed by: https://review.openstack.org/322017
    Remove mox from unit/api/openstack/compute/test_hide_server_addresses.py

Addressed by: https://review.openstack.org/322042
    Remove mox from compute/test_extended_volumes.py

Addressed by: https://review.openstack.org/322049
    Remove mox from compute/test_extension_info.py

Addressed by: https://review.openstack.org/322609
    Remove mox from api/openstack/compute/test_extensions.py

Addressed by: https://review.openstack.org/322622
    Remove mox from api/openstack/compute/test_flavor_rxtx.py

Addressed by: https://review.openstack.org/322624
    Remove mox from api/openstack/compute/test_floating_ip_pools.py

Addressed by: https://review.openstack.org/322629
    Remove mox from api/openstack/compute/test_fping.py

Addressed by: https://review.openstack.org/322641
    Remove mox from api/openstack/compute/test_floating_ip_dns.py

Addressed by: https://review.openstack.org/322665
    Remove mox from nova/tests/unit/virt/xenapi/test_volumeops.py

Addressed by: https://review.openstack.org/322668
    Remove mox from api/openstack/compute/test_floating_ips.py

Addressed by: https://review.openstack.org/322686
    Remove mox from nova/tests/unit/virt/xenapi/test_driver.py

Addressed by: https://review.openstack.org/322690
    Remove mox from api/openstack/compute/test_image_size.py

Addressed by: https://review.openstack.org/322699
    Remove mox from compute/test_instance_usage_audit_log.py

Addressed by: https://review.openstack.org/322710
    Remove mox from test_keypairs.py, test_limits.py

Addressed by: https://review.openstack.org/322733
    Stop using mox stubs in test_server_usage.py

Addressed by: https://review.openstack.org/322742
    Stop using mox stubs in nova/tests/unit

Addressed by: https://review.openstack.org/322754
    Remove mox from nova/tests/unit/test_configdrive2.py

Addressed by: https://review.openstack.org/322778
    Stop using mox stubs in nova/tests/unit/virt/disk

Addressed by: https://review.openstack.org/323055
    Remove mox from api/openstack/compute/test_networks.py

Addressed by: https://review.openstack.org/323093
    Remove mox from compute/test_neutron_security_groups.py

Addressed by: https://review.openstack.org/323100
    Remove mox from api/openstack/compute/test_pci.py

Addressed by: https://review.openstack.org/323102
    Remove mox from api/openstack/compute/test_remote_consoles.py

Addressed by: https://review.openstack.org/323105
    Remove mox from api/openstack/compute/test_rescue.py

Addressed by: https://review.openstack.org/323107
    Remove mox from compute/test_scheduler_hints.py

Addressed by: https://review.openstack.org/323112
    Remove mox from compute/test_server_metadata.py

Addressed by: https://review.openstack.org/323114
    Remove mox from compute/test_server_password.py

Addressed by: https://review.openstack.org/323122
    Stop using mox from compute/test_security_groups.py

Addressed by: https://review.openstack.org/323165
    Remove mox from nova/tests/unit/db/test_db_api.py

Addressed by: https://review.openstack.org/323186
    Stop using mox from compute/test_server_actions.py

Addressed by: https://review.openstack.org/323213
    Remove mox from nova/tests/unit/compute/test_virtapi.py

Addressed by: https://review.openstack.org/323226
    Stop using mox from compute/test_used_limits.py

Addressed by: https://review.openstack.org/323248
    Stop using mox from compute/test_user_data.py

Addressed by: https://review.openstack.org/323257
    Stop using mox from compute/test_volumes.py

Addressed by: https://review.openstack.org/323276
    Stop using mox from unit/api/openstack/test_wsgi.py

Addressed by: https://review.openstack.org/323287
    Stop using mox stubs in nova/tests/unit/cells

Addressed by: https://review.openstack.org/323288
    Remove mox from nova/tests/unit/virt/test_virt.py

Addressed by: https://review.openstack.org/323681
    Stop using mox from compute/test_flavorextradata.py

Addressed by: https://review.openstack.org/323688
    Remove mox from nova/tests/unit/test_iptables_network.py

Addressed by: https://review.openstack.org/323717
    Stop using mox from virt/libvirt/test_imagecache.py

Addressed by: https://review.openstack.org/323729
    Stop using mox from virt/libvirt/storage/test_lvm.py

Addressed by: https://review.openstack.org/323730
    Stop using mox stubs in fake_notifier

Addressed by: https://review.openstack.org/321450
    Remove mox from unit/api/openstack/compute/test_consoles.py

Addressed by: https://review.openstack.org/323812
    Remove mox from nova/tests/unit/virt/libvirt/

Addressed by: https://review.openstack.org/324176
    Remove mox from nova/tests/unit/virt/libvirt/test_utils.py

Addressed by: https://review.openstack.org/324229
    Stop using mox from unit/fake_network.py

Addressed by: https://review.openstack.org/324239
    Stop using mox from unit/fake_processutils.py

Addressed by: https://review.openstack.org/324272
    Stop using mox from unit/fake_server_actions.py

Addressed by: https://review.openstack.org/324292
    Stop using mox from unit/fake_utils.py

Addressed by: https://review.openstack.org/324335
    Stop using mox from unit/test_nova_manage.py

Addressed by: https://review.openstack.org/324346
    Stop using mox stubs in stub_out_key_pair_funcs

Addressed by: https://review.openstack.org/324373
    Stop using mox stubs in nova/tests/unit/test_metadata.py

Addressed by: https://review.openstack.org/325759
    Stop using mox from api/openstack/fakes.py

Addressed by: https://review.openstack.org/325819
    Stop using mox from compute/test_multiple_create.py

Addressed by: https://review.openstack.org/326245
    Stop using mox from objects/test_instance.py (1)

Addressed by: https://review.openstack.org/326260
    Stop using mox from objects/test_instance.py (2)

Addressed by: https://review.openstack.org/326267
    Stop using mox from objects/test_instance.py (3)

Addressed by: https://review.openstack.org/326814
    Stop using mox from compute/test_hypervisors.py

Addressed by: https://review.openstack.org/327447
    Stop using mox from openstack/compute/test_cells.py

Addressed by: https://review.openstack.org/327448
    Remove mox from unit/compute/test_compute_mgr.py (1)

Addressed by: https://review.openstack.org/327457
    Stop using mox from virt/xenapi/image/test_glance.py

Addressed by: https://review.openstack.org/327487
    Remove mox from unit/compute/test_compute_mgr.py (2)

Addressed by: https://review.openstack.org/327538
    Remove mox from unit/compute/test_compute_mgr.py (3)

Addressed by: https://review.openstack.org/327578
    Remove mox from unit/compute/test_compute_mgr.py (4)

Addressed by: https://review.openstack.org/328070
    Stop using mox from virt/libvirt/test_driver.py (1)

Gerrit topic: https://review.openstack.org/#q,topic:bp/versioned-notification-transformation-newton,n,z

Addressed by: https://review.openstack.org/328197
    Stop using mox stubs in tests/unit/fake_notifier

Addressed by: https://review.openstack.org/328816
    Remove mox from unit/compute/test_compute_mgr.py (5)

Addressed by: https://review.openstack.org/328825
    Stop using mox from virt/libvirt/test_driver.py (2)

Addressed by: https://review.openstack.org/328835
    Remove mox from unit/compute/test_compute_mgr.py (6)

Addressed by: https://review.openstack.org/328868
    Remove mox from unit/compute/test_compute_mgr.py (7)

Addressed by: https://review.openstack.org/328874
    Remove mox from unit/compute/test_compute_mgr.py (8)

Addressed by: https://review.openstack.org/328893
    Stop using mox from virt/libvirt/test_driver.py (3)

Addressed by: https://review.openstack.org/328908
    Remove mox from unit/compute/test_compute_mgr.py (end)

Addressed by: https://review.openstack.org/328944
    Remove mox from unit/compute/test_compute.py (1)

Gerrit topic: https://review.openstack.org/#q,topic:bug/1580625,n,z

Addressed by: https://review.openstack.org/329280
    Remove mox in test_volume_snapshot_create_outer_success

Addressed by: https://review.openstack.org/329747
    Stop using mox from virt/libvirt/test_driver.py (4)

Addressed by: https://review.openstack.org/329786
    Remove mox from unit/compute/test_compute.py (2)

Addressed by: https://review.openstack.org/329810
    Stop using mox from virt/libvirt/test_driver.py (5)

Addressed by: https://review.openstack.org/329860
    Remove mox from unit/compute/test_compute.py (3)

Addressed by: https://review.openstack.org/330297
    Remove mox from unit/compute/test_compute.py (4)

Addressed by: https://review.openstack.org/330429
    Remove mox from unit/compute/test_compute.py (5)

Addressed by: https://review.openstack.org/330460
    Remove mox from unit/compute/test_compute.py (6)

Addressed by: https://review.openstack.org/330898
    Remove mox from unit/compute/test_compute.py (7)

Addressed by: https://review.openstack.org/330948
    Remove mox from unit/compute/test_compute.py (8)

Addressed by: https://review.openstack.org/330964
    Remove mox from unit/compute/test_compute.py (9)

Addressed by: https://review.openstack.org/331013
    Remove mox from unit/compute/test_compute.py (10)

Addressed by: https://review.openstack.org/331507
    Remove mox from unit/compute/test_compute.py (11)

Addressed by: https://review.openstack.org/331569
    Remove mox from unit/compute/test_compute.py (end)

Addressed by: https://review.openstack.org/331588
    Stop using mox from virt/libvirt/test_driver.py (6)

Addressed by: https://review.openstack.org/331608
    Stop using mox from virt/libvirt/test_driver.py (end)

Addressed by: https://review.openstack.org/332653
    Replace mox.ContainsKeyValue with Class ContainsKeyValue

Addressed by: https://review.openstack.org/333101
    Stop using mox from unit/cells/test_cells_rpc_driver.py

Addressed by: https://review.openstack.org/321467
    Remove mox from unit/virt/libvirt/volume/*.py

Addressed by: https://review.openstack.org/333851
    Remove mox in nova/tests/unit/cells/test_cells_manager.py

Addressed by: https://review.openstack.org/334167
    Remove mox in unit/cells/test_cells_manager.py

Addressed by: https://review.openstack.org/334174
    Remove mox in nova/tests/unit/cells/test_cells_manager.py

Addressed by: https://review.openstack.org/334184
    Remove mox from nova/tests/unit/cells/test_cells_manager.py

Addressed by: https://review.openstack.org/334185
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(2)

Addressed by: https://review.openstack.org/334186
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(3)

Addressed by: https://review.openstack.org/334187
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(4)

Addressed by: https://review.openstack.org/334189
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(5)

Addressed by: https://review.openstack.org/334190
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(5)

Addressed by: https://review.openstack.org/334232
    Remove mox from nova/tests/unit/cells/test_cells_manager.py(6)

Addressed by: https://review.openstack.org/334297
    Remove mox in nova/tests/unit/api/openstack/compute (1)

Addressed by: https://review.openstack.org/334395
    Stop using mox from tests/unit/test_service.py

Addressed by: https://review.openstack.org/334409
    Remove mox from unit/virt/libvirt/test_imagebackend.py (1)

Addressed by: https://review.openstack.org/334841
    Remove mox from unit/compute/test_compute_api.py (1)

Addressed by: https://review.openstack.org/334848
    Stop using mox from unit/virt/xenapi/stubs.py

Addressed by: https://review.openstack.org/335411
    Remove mox from unit/virt/libvirt/test_imagebackend.py (2)

Addressed by: https://review.openstack.org/335765
    Remove mox from unit/virt/libvirt/test_imagebackend.py (3)

Addressed by: https://review.openstack.org/335820
    Remove mox from unit/virt/libvirt/test_imagebackend.py (4)

Addressed by: https://review.openstack.org/335921
    Remove mox from unit/virt/libvirt/test_imagebackend.py (5)

Addressed by: https://review.openstack.org/335925
    Remove mox from unit/virt/libvirt/test_imagebackend.py (end)

FYI, there is a deadline of 7/28 for this work in the Newton release. Anything that's not done by that point will need to wait for Ocata. -- mriedem 20160706

Addressed by: https://review.openstack.org/340660
    Remove mox from unit/compute/test_compute_api.py(2)

Addressed by: https://review.openstack.org/340713
    Remove mox from unit/compute/test_compute.py

Addressed by: https://review.openstack.org/342043
    Stop using mox stubs in nova/tests/unit/cells/fakes.py

Addressed by: https://review.openstack.org/342061
    Stop using mox from unit/virt/disk/test_api.py

Addressed by: https://review.openstack.org/342546
    Remove mox in nova/tests/unit/compute/test_shelve.py (1)

Addressed by: https://review.openstack.org/342593
    Remove mox in nova/tests/unit/compute/test_shelve.py (2)

Addressed by: https://review.openstack.org/342595
    Stop using mox from unit/virt/test_block_device.py

Addressed by: https://review.openstack.org/342626
    Stop using mox from unit/virt/xenapi/image/test_utils.py

Addressed by: https://review.openstack.org/342648
    Remove mox in nova/tests/unit/compute/test_shelve.py (3)

Addressed by: https://review.openstack.org/342649
    Remove mox in nova/tests/unit/compute/test_shelve.py (end)

Addressed by: https://review.openstack.org/342682
    Stop using mox from virt/xenapi/image/test_vdi_through_dev.py

Addressed by: https://review.openstack.org/343465
    Completely remove mox from objects/test_instance.py

Addressed by: https://review.openstack.org/344000
    Stop using mox from unit/virt/xenapi/test_vmops.py (1)

Addressed by: https://review.openstack.org/344010
    Stop using mox from unit/virt/xenapi/test_vmops.py (end)

Addressed by: https://review.openstack.org/344054
    Stop using mox from unit/virt/xenapi/test_vm_utils.py (1)

Addressed by: https://review.openstack.org/347248
    Remove mox in tests/unit/objects/test_service

Gerrit topic: https://review.openstack.org/#q,topic:libvirt-instance-storage,n,z

Addressed by: https://review.openstack.org/329421
    Only attempt to inject files if the injection disk exists

This is partially complete for newton, I've created a blueprint to continue this in ocata:

https://blueprints.launchpad.net/nova/+spec/remove-mox-ocata

So start moving patches to that blueprint for ocata as this is closed for newton. -- mriedem 20160901

Gerrit topic: https://review.openstack.org/#q,topic:bp/remove-mox-ocata,n,z

Addressed by: https://review.openstack.org/389750
    Stop using mox in test_compute_cells.py

Addressed by: https://review.openstack.org/399036
    Remove mox in unit/cells/test_cells_manager.py

Addressed by: https://review.openstack.org/401112
    Remove mox from tests/unit/api/openstack/compute/test_extended_volumes.py

(?)

Work Items

Dependency tree

* Blueprints in grey have been implemented.

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.