libvirt: driver class refactoring

Registered by Daniel Berrange on 2014-07-04

The libvirt class is growing ever larger and more complicated.
There are circular dependencies between this class and other libvirt
classes. This work aims to split some of the functionality out into
new classes

Blueprint information

John Garbutt
Daniel Berrange
Daniel Berrange
Series goal:
Accepted for kilo
Milestone target:
milestone icon 2015.1.0
Started by
John Garbutt on 2014-07-11
Completed by
John Garbutt on 2015-01-27

Related branches



Gerrit topic:,topic:libvirt-driver-class-refactor,n,z

Addressed by:
    Libvirt driver class refactoring

Gerrit topic:,topic:bp/libvirt-driver-class-refactor,n,z

Addressed by:
    libvirt: introduce new 'Host' class to manage the connection

Its Feature Proposal Freeze now, so lets call this partially complete for juno. No more juno patches please. --johnthetubaguy 22nd August 2014

Sorry, this does not have enough positive reviews to make it for juno-3, please resubmit for kilo. For more information, please contact me (johnthetubaguy) via IRC or email. --johnthetubaguy 2nd September 2014

This doesn't need a spec for kilo, approved. --johnthetubaguy

Addressed by:
    virt: delete unused 'interface_stats' method

Addressed by:
    virt: Convert more tests to use instance objects

Addressed by:
    libvirt: Convert more tests to use instance objects

Addressed by:
    virt: pass instance object to block_stats & get_instance_disk_info

Addressed by:
    libvirt: introduce a fixture for mocking out libvirt connections

Addressed by:
    libvirt: convert to use FakeLibvirtFixture

Addressed by:
    libvirt: sanitize use of mocking in

Addressed by:
    libvirt: remove unused get_connection parameter from VIF driver

Addressed by:
    libvirt: pass Host object into firewall class

Addressed by:
    libvirt: remove pointless _get_host_uuid method

Addressed by:
    libvirt: introduce new helper for getting libvirt domain

Addressed by:
    libvirt: move domain lookup helpers into Host class

Addressed by:
    libvirt: move domain list helpers into Host class

Addressed by:
    libvirt: move capabilities helper into

Addressed by:
    libvirt: remove/revert pointless logic for getVersion call

Addressed by:
    libvirt: move _get_hypervisor_* functions to Host class

Addressed by:
    libvirt: convert LibvirtConnTestCase to use fakelibvirt fixture

Addressed by:
    libvirt: rename self.libvirtconnection in LibvirtDriverTestCase

Addressed by:
    libvirt: rename self.conn in LibvirtVolume{Snapshot||Usage}TestCase

Addressed by:
    libvirt: rename conn variable in LibvirtConnTestCase

Moving to kilo-2, as its not been moved into the NeedsCodeReview state, it is assumed that not all patches are yet up for review. --johnthetubaguy 16th December 2014

Gerrit topic:,topic:libvirt-driver-refactor-3,n,z

Gerrit topic:,topic:libvirt-driver-refactor-4,n,z

All patches merged, now reached feature proposal freeze, marking as complete. --johnthetubaguy 26th Jan 2015


Work Items

This blueprint contains Public information 
Everyone can see this information.