Stop using both flavors and instance types, as they are synonyms

Registered by Joe Gordon

Nova currently uses the terms flavor and instance type interchangeably in both user facing tools and in code. Lets pick just one.

Blueprint information

Status:
Started
Approver:
Russell Bryant
Priority:
Undefined
Drafter:
Joe Gordon
Direction:
Needs approval
Assignee:
Matt Riedemann
Definition:
Review
Series goal:
None
Implementation:
Good progress
Milestone target:
None
Started by
Joe Gordon

Related branches

Sprints

Whiteboard

"russellb: stick with our own terminology (flavor) except when specifically doing EC2 handling IMO" ~ 2013-3-4

Gerrit topic: https://review.openstack.org/#q,topic:bp/flavor-instance-type-dedup,n,z

Addressed by: https://review.openstack.org/28456
    Rename nova.compute.instance_types to flavors

Addressed by: https://review.openstack.org/29020
    Rename functions in nova.compute.flavors from instance_type

Addressed by: https://review.openstack.org/36234
    Change db.api.instance_type_ to db.api.flavor_

Addressed by: https://review.openstack.org/36235
    Use db.flavor_ instead of db.instance_type_

Addressed by: https://review.openstack.org/36436
    Clarify instance_type vs flavor in nova-manage

Addressed by: https://review.openstack.org/53132
    Remove instance_type* proxy methods from nova.db.api

Gerrit topic: https://review.openstack.org/#q,topic:bp-flavor-instance-type-dedup,n,z

Addressed by: https://review.openstack.org/56109
    Rename virtapi.instance_type_get to flavor_get

Addressed by: https://review.openstack.org/56317
    More instance_type -> flavor renames in db.api

Addressed by: https://review.openstack.org/56642
    Rename InstanceType exceptions to Flavor

Addressed by: https://review.openstack.org/58383
    Rename instance_type parameter in migrate_disk_and_power_off to flavor

Addressed by: https://review.openstack.org/59277
    Rename instance_type to flavor in baremetal virt driver

Addressed by: https://review.openstack.org/59607
    Rename instance_type to flavor in test_utils.py

Addressed by: https://review.openstack.org/59613
    Rename instance_type to flavor in nova.tests.utils

Addressed by: https://review.openstack.org/60716
    Rename instance_type to flavor in xenapi virt driver

Addressed by: https://review.openstack.org/60719
    Rename instance_type to flavor in hyper-v virt driver

Addressed by: https://review.openstack.org/60733
    Rename instance_type to flavor in vmware virt driver tests

Addressed by: https://review.openstack.org/61261
    Rename instance_type to flavor in libvirt virt driver tests

Addressed by: https://review.openstack.org/62194
    Rename instance_type to flavor in nova.network tree

Addressed by: https://review.openstack.org/62253
    Rename instance_type to flavor in nova.cloudpipe

Addressed by: https://review.openstack.org/62254
    Rename instance_type to flavor in nova.utils and nova.compute.utils

Addressed by: https://review.openstack.org/62430
    Rename instance_type to flavor in notifications

Addressed by: https://review.openstack.org/64714
    Remove get_instance_type from nova.compute.api

Unapproved - please re-submit via nova-spec --johnthetubagy (20th March 2014)

Removed from next, as next is now reserved for near misses from the last milestone --johnthetubaguy

Addressed by: https://review.openstack.org/109914
    Rename instance_type to flavor in notifications

Addressed by: https://review.openstack.org/135302
    Virt: change instance_type to flavor

Addressed by: https://review.openstack.org/122558
    object-ify flavors manager side of the RPC

(?)

Work Items

Work items:
Rename files from instance_type(s) to flavor(s): DONE
Rename variables: INPROGRESS
Make sure instance_type is only in EC2 handling code: INPROGRESS
Make sure instance_type is not in python-novaclient: TODO
Update nova docs: TODO
Remove nova.db.api proxies: DONE
Rename nova.virt.virtapi.instance_type_get: DONE
Rename instance_type_get in the APIs: TODO
Rename arg in migrate_disk_and_power_off virt driver method: DONE
Final pass on tests and misc cleanup: TODO
Rename exceptions: DONE
Rename DB models: TODO
Cleanup nova.test.utils: INPROGRESS

This blueprint contains Public information 
Everyone can see this information.