Remove unpythonic execs of system commands

Registered by Michael Still

Nova has lots of places where we exec() commands like rm, mv, cp, dd, mkdir, etc instead of using the pythonic alternative. This is slower, and makes unit testing harder. Also, it makes us look silly at social occasions. We should clean this up.

Additionally, now that utils.execute() is just a wrapper around processutils.execute(), we should just call processutils directly and kill the wrapper.

Blueprint information

Status:
Complete
Approver:
Matt Riedemann
Priority:
Low
Drafter:
Michael Still
Direction:
Approved
Assignee:
Michael Still
Definition:
Approved
Series goal:
Accepted for rocky
Implementation:
Implemented
Milestone target:
milestone icon rocky-3
Started by
Matt Riedemann
Completed by
melanie witt

Related branches

Sprints

Whiteboard

Gerrit topic: https://review.openstack.org/#q,topic:bp/execs-ive-had-a-few,n,z

Addressed by: https://review.openstack.org/554791
    Remove duplicative implementation of temporary directories.

Addressed by: https://review.openstack.org/554792
    Use a pythonic delete.

Addressed by: https://review.openstack.org/554793
    Use a pythonic delete, with a retry.

Approved as a specless blueprint for Rocky. -- mriedem 20180322

Addressed by: https://review.openstack.org/562463
    Use os.rename, not mv.

Addressed by: https://review.openstack.org/564144
    Convert fping API to processutils.execute()

Addressed by: https://review.openstack.org/564145
    Convert xenapi's xvp console to processutils.

Addressed by: https://review.openstack.org/564146
    Convert certificate generation to processutils.

Addressed by: https://review.openstack.org/565723
    Convert configdrive to use processutils.

Addressed by: https://review.openstack.org/569862
    Convert libvirt's RBD storage to using processutils.execute()

Closing this out for Rocky as all proposed changes have merged and we're coming up on r-3 feature freeze on July 26. -- melwitt 20180713

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.