EC2 API: Implement metadata tags for volumes and snapshots

Registered by Rushi Agrawal on 2014-01-13

Currently, the EC2 API of OpenStack only has tags support (metadata) for instances. This blueprint is to add support for volumes and volume snapshots

EC2 API reference:
CreateTags http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-CreateTags.html
DeleteTags http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DeleteTags.html
DescribeTags http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeTags.html

Blueprint information

Status:
Started
Approver:
John Garbutt
Priority:
Low
Drafter:
Rushi Agrawal
Direction:
Needs approval
Assignee:
Rushi Agrawal
Definition:
Pending Approval
Series goal:
None
Implementation:
Needs Code Review
Milestone target:
None
Started by
Rushi Agrawal on 2014-01-13

Related branches

Sprints

Whiteboard

Overall this BP looks good, clear scope and work already started. I would like to see some integration tests for this as well to make sure we don't break this in the future -- jogo (Feb 3, 2014)

Thanks Joe. I'll make sure I (or somebody else write integ tests soon for this) - Rushi (Feb 13, 2014)

The patches seem muddled between the two blueprints, that needs sorting. --johnthetubaguy

Apologies, this missed the deadline for Feature Freeze. Please rebase patches as soon as Juno opens, and we will try to get this in during that period. --johnthetubaguy (5th March 2014)

However seems like some of the approaches need to be discussed more, and we need a much clearer blueprint, with steps on what is being done, so we can try and stop blocking these changes after so much work has been done. Un-approving this one --johnthetubaguy

Submitted patch at nova-specs. Removed the confusing blueprints. Now there is only one, which is in Gerrit right now with the same name as this. --Rushi (April 04, 2014)

Because the spec is approved, I have now added this into Juno, after updating the blueprint URL. Please get some code uploaded, and choose an appropriate milestone before this blueprint can be approved --johnthetubaguy (23rd May 2014)

I changed the milestone to Juno-2. Code is up for review, passing check jobs. --Rushi (8 July '14)

Not all code is up for review yet, moving to juno-3 --johnthetubaguy (15th July 2014)

If all the code is now up for review, please mark the blueprint implementation stats as "Needs Code Review". The work items are assumed to be individual patches. Moving back to juno-2 to reflect this update. --johnthetubaguy (15th July 2014)

Reviews do not have +2s and are not close to approval, so moving to juno-3. But please move this back to juno-2, should you get your patches approved in time. --johnthetubaguy 21st July 2014

Gerrit topic: https://review.openstack.org/#q,topic:bp/ec2-volume-and-snapshot-tags,n,z

Addressed by: https://review.openstack.org/111563
    EC2: Reorganize code for EC2 tags

Addressed by: https://review.openstack.org/112325
    EC2: Implement volume tags (metadata) in EC2 API

Addressed by: https://review.openstack.org/113088
    EC2: Implement volume snapshot tags

Sorry, this does not have enough positive reviews to make it for juno-3, please resubmit for kilo. For more information, please contact me (johnthetubaguy) via IRC or email. --johnthetubaguy 2nd September 2014

Addressed by: https://review.openstack.org/118554
    Move metadata filtering logic to utils.py

Addressed by: https://review.openstack.org/126553
    EC2: add support for volume and snapshot tags

Reapproved for kilo, please rebase patches, and mark as needs code review, when all ready to go. --johnthetubaguy 17th October 2014

Jenkins is still failing on some patches, and there have been no new revisions, this doesn't seem read for review, so moving back to started, and moving into kilo-2. --johnthetubaguy 17th December 2014

Its really late now for kilo, and we are looking at pulling ec2, lets push this out for now till we can decide. --johnthetubaguy 4th Feb 2015

(?)

Work Items

Work items:
Implement volume and snapshot tags: INPROGRESS

This blueprint contains Public information 
Everyone can see this information.