Fix overwriting of builtins

Registered by Alvaro Lopez

There are a lot of builins overwritten in the code (type, id, filter, etc). According to the HACKING rules ( we should not shadow them.

Blueprint information

Not started
Russell Bryant
Alvaro Lopez
Needs approval
Series goal:
Not started
Milestone target:
milestone icon next

Related branches



I would almost say that these should be tracked by bugs instead, but organizing the work under a blueprint is okay for now. --alaski

I think the first step for this is to provide a way to gate on this, which as far as I know we don't have one at the moment. Until then I don't think this is worth it -- jogo

alasaki: I agree with you about tracking the work that needs to be done by bugs, but I think that having a blueprint to organize the work and reviews is useful -- aloga
jogo: Yes, indeed. Otherwise nothing prevents new commiters to shade again the builtins -- aloga

@jogo: There's a gate job that runs pylint (although it is not scoring). Would it be enough, or would you prefer it into hacking? The former should be easy to implement, whereas the former would need more coding -- aloga

aloga, I don't care if this is enforced via pylint of hacking, but I do want to be able to gate on this. If you update the BP to add a work item to provide a mechanism to gate on this as the first step, I would happy to approve this blueprint -- jogo

looks like the gate test item was added, so i'll approve. thanks! --russellb

At this point since this blueprint is still marked as Not Started, I think it should be deferred to Juno. I'd rather not have cleanup churn going through at the end of the cycle. This sort of thing is much better at the beginning of the cycle. --russellb

Unapproved - please re-submit via nova-spec --johnthetubagy (20th March 2014)


Work Items

Work items:
[aloga] gate test: TODO
[aloga] fix overwritten builtins: TODO

This blueprint contains Public information 
Everyone can see this information.