Allow including @ and dot (.) characters in keypair name

Registered by Nautik

Keypair names currently only allow digits, ascii letters and "_- "

But some users (a lot?) try to create their keypair including a '@' or '.' (dot) symbol in it, which is not allowed.
This "convention" or habit might come from the default comment generated by ssh-keygen, which is user@host.

Allowing the '@' and '.' characters in keypair name looks like a small change improving user experience.

Blueprint information

Status:
Started
Approver:
Balazs Gibizer
Priority:
Undefined
Drafter:
Nautik
Direction:
Approved
Assignee:
Nautik
Definition:
Pending Approval
Series goal:
None
Implementation:
Started
Milestone target:
None
Started by
Nautik

Related branches

Sprints

Whiteboard

Related code & history:
- Checked by https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L6343
- Check was introduced by https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993, to resolve https://bugs.launchpad.net/nova/+bug/937408
- Only modified once since to include space in https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675

We discussed this a bit on IRC and agreed that it needs a new API microversion and hence a spec. See http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2021-03-19.log.html#t2021-03-19T10:02:01

[20210504 gibi]: spec has been merged so this is approved for Xena
Implementation: https://review.opendev.org/c/openstack/nova/+/781076

[2021-09-07 gibi]: We hit feature freeze so it is now deferred from Xena.

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.