Comment 8 for bug 1843639

Reviewed: https://review.opendev.org/682622
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ac68cffd43a2f5103c28a2d4b31e087c3f5c24b9
Submitter: Zuul
Branch: master

commit ac68cffd43a2f5103c28a2d4b31e087c3f5c24b9
Author: Lee Yarwood <email address hidden>
Date: Wed Sep 11 19:24:05 2019 +0100

    libvirt: Ignore volume exceptions during post_live_migration

    Previously errors while disconnecting volumes from the source host
    during post_live_migration within LibvirtDriver would result in the
    overall failure of the migration. This would also mean that while the
    instance would be running on the destination it would still be listed as
    running on the source within the db.

    This change simply ignores any exceptions raised while attempting to
    disconnect volumes on the source. These errors can be safely ignored as
    they will have no impact on the running instance on the destination.

    In the future Nova could wire up the force and ignore_errors kwargs when
    calling down into the associated os-brick connectors to help avoid this.

    Closes-Bug: #1843639
    Change-Id: Ieff5243854321ec40f642845e87a0faecaca8721