libvirt: Ignore volume exceptions during post_live_migration
Previously errors while disconnecting volumes from the source host
during post_live_migration within LibvirtDriver would result in the
overall failure of the migration. This would also mean that while the
instance would be running on the destination it would still be listed as
running on the source within the db.
This change simply ignores any exceptions raised while attempting to
disconnect volumes on the source. These errors can be safely ignored as
they will have no impact on the running instance on the destination.
In the future Nova could wire up the force and ignore_errors kwargs when
calling down into the associated os-brick connectors to help avoid this.
NOTE(mriedem): The driver.py change is slightly different from Train
because pep F841 was not enforced starting in Train but is in Stein.
Closes-Bug: #1843639
Change-Id: Ieff5243854321ec40f642845e87a0faecaca8721
(cherry picked from commit ac68cffd43a2f5103c28a2d4b31e087c3f5c24b9)
(cherry picked from commit ff36b6d97ff289ddc34d7776f6a9141b09eb3ad9)
Reviewed: https:/ /review. opendev. org/691282 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=022ea281942 5b5ab3001791455 dda36ed638c22d
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 022ea2819425b5a b3001791455dda3 6ed638c22d
Author: Lee Yarwood <email address hidden>
Date: Wed Sep 11 19:24:05 2019 +0100
libvirt: Ignore volume exceptions during post_live_migration
Previously errors while disconnecting volumes from the source host
during post_live_migration within LibvirtDriver would result in the
overall failure of the migration. This would also mean that while the
instance would be running on the destination it would still be listed as
running on the source within the db.
This change simply ignores any exceptions raised while attempting to
disconnect volumes on the source. These errors can be safely ignored as
they will have no impact on the running instance on the destination.
In the future Nova could wire up the force and ignore_errors kwargs when
calling down into the associated os-brick connectors to help avoid this.
NOTE(mriedem): The driver.py change is slightly different from Train
because pep F841 was not enforced starting in Train but is in Stein.
Closes-Bug: #1843639 c40f642845e87a0 faecaca8721 03c28a2d4b31e08 7c3f5c24b9) dc34d7776f6a914 1b09eb3ad9)
Change-Id: Ieff5243854321e
(cherry picked from commit ac68cffd43a2f51
(cherry picked from commit ff36b6d97ff289d