Comment 6 for bug 1837955

Reviewed: https://review.opendev.org/672855
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df
Submitter: Zuul
Branch: master

commit b98d4ba6d54f5ca2999a8fe6b6d7dfcc134061df
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Jul 25 20:19:40 2019 -0700

    Cleanup when hitting MaxRetriesExceeded from no host_available

    Prior to this patch there was a condition when no
    host_available was true and an exception would get
    raised without first cleaning up the instance.
    This causes instances to get indefinitely stuck in
    a scheduling state.

    This patch fixes this by calling the clean up function
    and then exits build_instances using a return statement.

    The related functional regression recreate test is updated
    to show this fixes the bug.

    Change-Id: I6a2c63a4c33e783100208fd3f45eb52aad49e3d6
    Closes-bug: #1837955