Comment 3 for bug 1490767

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

For damage control: I don't believe we can attach the geneve migration script to expand now. I also don't believe it's a disaster: we only put some operations that could be executed when service is up to offline phase.

I believe part of the problem here is lack of reviewer attention to the paths, but that's understandable: gerrit does not show paths in meaningful way when you review file after file.

The test to validate semantical correctness of operations could rely on Mike Bayer's autogenerate code that already has some kind of operation classification: https://review.openstack.org/#/c/203842/9/neutron/db/migration/autogen.py

I wonder whether it should be not a test that could be missed in a subproject, but a check that is embedded in upgrade command, that would make sure you cannot run a wrong migration script until the script is fixed. That could expand our sanity checks in neutron-db-manage that currently consist of a single check for security groups.