Add js linting jobs to murano-dashboard

Registered by Kirill Zaitsev

(Split from https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs)

To ensure good quality of js files murano-dashboard should have js-linter jobs. Horizon is currently adopting JP style guide and eslint, we could adopt the same tools for the purpose.
see https://review.openstack.org/#/c/192327/ and http://lists.openstack.org/pipermail/openstack-dev/2015-June/067030.html for reasons to choose eslint over every other linting options

Muranodashboard should have a js linting job, which should be added as non-voting at first.
After that we should fix all the errors and make the job working.

Blueprint information

Status:
Complete
Approver:
Serg Melikyan
Priority:
Medium
Drafter:
Kirill Zaitsev
Direction:
Approved
Assignee:
Kirill Zaitsev
Definition:
Drafting
Series goal:
None
Implementation:
Implemented
Milestone target:
None
Started by
Kirill Zaitsev
Completed by
Kirill Zaitsev

Related branches

Sprints

Whiteboard

Gerrit topic: https://review.openstack.org/#q,topic:bp/add-shellcheck-jobs,n,z

Addressed by: https://review.openstack.org/200780
    Add eslint javascript checker

Gerrit topic: https://review.openstack.org/#q,topic:bp/add-js-lint-jobs,n,z

Addressed by: https://review.openstack.org/203453
    Cleanup environments-in-place.js

Addressed by: https://review.openstack.org/205325
    eslint cleanup of smaller js files

Addressed by: https://review.openstack.org/205329
    eslint cleanup of passwordfield.js

Addressed by: https://review.openstack.org/206248
    eslint cleanup of draggable-components.js

Addressed by: https://review.openstack.org/206347
    eslint cleanup of import_bundle_form.js

Addressed by: https://review.openstack.org/206354
    eslint cleanup of passwordfield.js

Gerrit topic: https://review.openstack.org/#q,topic:bug/1477107,n,z

Addressed by: https://review.openstack.org/206729
    Adopt openstack-config for eslint

Addressed by: https://review.openstack.org/206786
    eslint cleanup of load-modals.js

Addressed by: https://review.openstack.org/206798
    eslint cleanup of support_placeholder.js

Addressed by: https://review.openstack.org/206803
    eslint cleanup of external-ad.js

Addressed by: https://review.openstack.org/206884
    eslint cleanup of add-select.js

Addressed by: https://review.openstack.org/206961
    eslint cleanup of horizon.muranotopology.js

Addressed by: https://review.openstack.org/208145
    Fix eslint checks from openstack config

(?)

Work Items

Work items:
Add non-voting js lint jobs to murano-dashboard: DONE
Fix any errors, reported by lint jobs: DONE
Make lint jobs voting: DONE

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.