Add hacking to automate code styling
Hacking is a great start at automating checks for common style issues. There are still lots of things that it is not checking for that it probably should. This is the list of things that would be nice to move into an automated check:
- block comments should have a space after the # (this is already enforced for inline comments)
- hacking checks for xrange()
- Enforce use of assertTrue/
- Enforce use of assertIs/
- checks for deprecated LOG.warn()
- do not use dict.iteritems
- do not use dict.iterkeys
- do not use dict.itervalues
- do not use basestring
Blueprint information
- Status:
- Complete
- Approver:
- Renat Akhmerov
- Priority:
- Medium
- Drafter:
- Sharat Sharma
- Direction:
- Approved
- Assignee:
- Sharat Sharma
- Definition:
- Approved
- Series goal:
- Proposed for ocata
- Implementation:
-
Implemented
- Milestone target:
- None
- Started by
- Sharat Sharma
- Completed by
- Sharat Sharma
Related branches
Related bugs
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Enforce style check for assertIsNone
Addressed by: https:/
Enforce style check for xrange()
Addressed by: https:/
Added style enfore checks for assert statements
Addressed by: https:/
Enforce style check for xrange()
Addressed by: https:/
Add hacking for code style checks
