Add hacking to automate code styling

Registered by Sharat Sharma on 2017-01-11

Hacking is a great start at automating checks for common style issues. There are still lots of things that it is not checking for that it probably should. This is the list of things that would be nice to move into an automated check:

 - block comments should have a space after the # (this is already enforced for inline comments)
 - hacking checks for xrange()
 - Enforce use of assertTrue/assertFalse
 - Enforce use of assertIs/assertIsNot
 - checks for deprecated LOG.warn()
 - do not use dict.iteritems
- do not use dict.iterkeys
- do not use dict.itervalues
- do not use basestring

Blueprint information

Status:
Complete
Approver:
Renat Akhmerov
Priority:
Medium
Drafter:
Sharat Sharma
Direction:
Approved
Assignee:
Sharat Sharma
Definition:
Approved
Series goal:
Proposed for ocata
Implementation:
Implemented
Milestone target:
None
Started by
Sharat Sharma on 2017-03-16
Completed by
Sharat Sharma on 2017-04-11

Related branches

Sprints

Whiteboard

Gerrit topic: https://review.openstack.org/#q,topic:bp/mistral-hacking,n,z

Addressed by: https://review.openstack.org/420405
    Enforce style check for assertIsNone

Addressed by: https://review.openstack.org/428116
    Enforce style check for xrange()

Addressed by: https://review.openstack.org/431427
    Added style enfore checks for assert statements

Addressed by: https://review.openstack.org/434825
    Enforce style check for xrange()

Addressed by: https://review.openstack.org/435395
    Add hacking for code style checks

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.