Android Code Review

Registered by Zach Pfeffer

This discussion will focus on Android code review. Topics will include Gerrit, continuous integration, maintainers, reviewers and validation. We'll focus on integrating the Android development model with Linaro.

Short presentation to get session started :

Out of this session we need...
 1. A volunteer to set up gerrit server
 2. A volunteer one to configure gerrit
 3. roles
 4. rules (who and what can be pushed where)
 5. plan for how to combine gerrit, build server, lava...

Possible Action Items from the discussion:

1. Setup Gerrit.

2. Host trees in Gerrit.

3. Integrate Gerrit with Validation.

4. Implement Gerrit auto-merging.

5. Setup Gerrit upstream flow. Talk to Arnd to make sure the flow works for the kernel.

6. Integrate legal check in Gerrit loop.

7. Setup a contributor agreement for Gerrit submission.

8. Identify a subset of tests to run on each auto-merged result.

9. Create a mechanism for users to add and remove tests as well as add and remove from the test set.

10. Work with davidb to leverage work that's already been done.


Session notes:

Blueprint information

Not started
Zach Pfeffer
Patrik Ryd
Series goal:
Accepted for 2011q2
Milestone target:
milestone icon connect-q2.11

Related branches



The goal of this task is to setup and configure Gerrit to work within the validation, Launchpad and upstream frameworks we have. Overall Gerrit's code reviews should
update 110622 patrikryd: cleanup format below.

Arnd's user story for multi-branch development: (please feel free to move to blueprint description or more appropriate location.)


Work Items

Work items:
Setup a public host for Gerrit at POSTPONED
Install Gerrit: DONE
[pfalcon] Configure Gerrit for builds: DONE
[pfalcon] Demonstrate a basic patch submission, review and maintainer flow: DONE
[fgiff] Hook Gerrit to validation: DONE
[fgiff] Hook Gerrit to auto-merging: DONE
[fgiff] Hook Gerrit to auto builder: DONE
[pfalcon] Setup DONE
[pfalcon] Move android gits to DONE
[pfalcon] Host Android tree in Gerrit: DONE
[pfalcon] Host kernel tree in Gerrit: DONE
Host 0xbench tree in Gerrit: TODO
[pfalcon] Host toolchain in Gerrit: DONE
Host license files in Gerrit: TODO
Host proprietary blobs in Gerrit: TODO
Add and upstream a feature to Gerrit to allow users to add and remove tests: TODO
Add and upstream a feature for tracking license in Gerrit: TODO
Enable code checking (blackduck, whiteduck) in the Gerrit loop: TODO
Add upstream patch tracking: TODO
Add a feature to Gerrit to allow patches to be submitted upstream: TODO

Dependency tree

* Blueprints in grey have been implemented.