Comment 20 for bug 170225

Revision history for this message
jazzynico (jazzynico) wrote :

> I'm thinking that we want to do this in C++, not C.

I reused the same syntax as the original code. And since it was not part of the recent C++ification, it still needs refactoring.

> A minor shift in approach could be helpful.

Could you please give some details? Do you mean the patch could be made differently (and more efficiently) or the whole code?

Would you mind if I commit the current patch? As far as I can tell, it doesn't add any regression compared to how relative links worked with 0.46 and doesn't break anything else in Inkscape. If it's a matter of C++ification, I guess that's something we could do after the bug is fixed. Except of course if there are horrors in the patch...