Make table BatchAction help text configurable
This blueprint will provide a simple way to let horizon developer
could customize the BatchAction help text.
Summary
=======
Make table BatchAction help text configurable
Description
=========
Now the BatchAction help text is consistent:
"Please confirm your selection.This action cannot be undone."
It's useful for most of the table/row action. But for some
DeleteAction, inherited from BatchAction, this help text is not
clear enough for users to understand the consequence. The delete
action is mostly dangerous. The help text does not point out
what this action will cause.
Testing
======
Need table action tests.
Other Requirements
======
Need another patch to add all the important BatchAction/
with appropriate help text.
Blueprint information
- Status:
- Complete
- Approver:
- David Lyle
- Priority:
- Low
- Drafter:
- LIU Yulong
- Direction:
- Approved
- Assignee:
- LIU Yulong
- Definition:
- Approved
- Series goal:
- Accepted for kilo
- Implementation:
-
Implemented
- Milestone target:
-
2015.1.0
- Started by
- LIU Yulong
- Completed by
- LIU Yulong
Related branches
Related bugs
Sprints
Whiteboard
Add help text to BatchAction:
https:/
TODO: need another patch to add all the important BatchAction with Appropriate help text.
Gerrit topic: https:/
Addressed by: https:/
Make table BatchAction help text configurable
[Lin] Nov-17-2014 - Please format the description to follow the BP template here: https:/
asahlin: I think this is a good improvement to allow for customizable help text. Showing my horizon newbieness (is that a word :-) ) Why limit it to just batch & delete action classes is there other action classes that have confirmation / help text? If so should open this plug-ability to those as well.
[LIU Yulong Nov-25-2014] Batch & delete action does not need any form to handle the request. And there is no template for them to render. Other actions, mostly, open a form to handle the user request. In these forms' template html file, there is a block named "Description" where you can describe your action in great detail.
amotoki (Nov 27, 2014) - It is a good improvement.
One question: The description mentions "Needs another important patch for BatchAction" as a requirement. Could you share a link of a review or a blueprint? Without it, we cannot asses which milestone this blueprint fits to.
[LIU Yulong Nov-28-2014] Hi, I submitted another bp to do the "add help text" work. https:/
Gerrit topic: https:/
Addressed by: https:/
Add help text to DeleteAction
Addressed by: https:/
Add help text to BatchAction
Work Items
Dependency tree
* Blueprints in grey have been implemented.
