John Papa style guide cleanup
Summary:
Cleanup JS code with rules and refactor using John Papa's Angular Style Guide. Deprecate JSHint in the future.
Motivation:
We want to have clean, consistent code and rules. We want to eventually turn on some lint globally (https:/
Description:
We are following the rules listed by John Papa here: https:/
UX:
No impact.
Outside Dependencies:
N/A
Requirements Update Required:
Doc Impact:
Blueprint information
- Status:
- Complete
- Approver:
- David Lyle
- Priority:
- High
- Drafter:
- Cindy Lu
- Direction:
- Approved
- Assignee:
- None
- Definition:
- Approved
- Series goal:
- Accepted for liberty
- Implementation:
-
Implemented
- Milestone target:
-
8.0.0
- Started by
- Travis Tripp
- Completed by
- David Lyle
Related branches
Related bugs
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Adding John Papa style guide to JSCS
Gerrit topic: https:/
Addressed by: https:/
JSCS Cleanup - Legacy JS files
Addressed by: https:/
JSCS cleanup - Angular framework widgets (partial)
Addressed by: https:/
JSCS Cleanup - Legacy JS test files
Addressed by: https:/
JSCS cleanup - Angular framework widgets (partial2)
Addressed by: https:/
JSCS cleanup - Angular framework widgets (partial)
Addressed by: https:/
JSCS Cleanup - o_d/static/
Addressed by: https:/
JSCS Cleanup - dashboard-app
Addressed by: https:/
JSCS cleanup - horizon/
Addressed by: https:/
JSCS cleanup - horizon/static/auth
Addressed by: https:/
JSCS Cleanup - style guide cleanup for action-list
Addressed by: https:/
JSCS cleanup - style guide cleanup for charts
Addressed by: https:/
JSCS cleanup - style guide cleanup for help-panel and MagicSearch
Addressed by: https:/
JSCS cleanup - style guide cleanup for metadata-display
Addressed by: https:/
JSCS cleanup - style guide cleanup for modal-wait-spinner
Addressed by: https:/
JSCS cleanup - style guide cleanup for modal
Addressed by: https:/
JSCS Cleanup - style guide cleanup for toast
Addressed by: https:/
JSCS Cleanup - style guide cleanup for wizard
Addressed by: https:/
JSCS Cleanup - karma.conf
Addressed by: https:/
JSCS cleanup - style guide cleanup for table and basic-table
Addressed by: https:/
JSCS cleanup - launch-
Addressed by: https:/
JSCS cleanup - launch-
Addressed by: https:/
JSCS cleanup - launch-
Addressed by: https:/
JSCS cleanup - launch-instance/
Addressed by: https:/
JSCS cleanup - launch-
Addressed by: https:/
JSCS Cleanup - style guide cleanup for transfer-table
Addressed by: https:/
JSCS Cleanup - Utils folder (partial)
Addressed by: https:/
JSCS Cleanup - style cleanup for Flavor Step
Addressed by: https:/
JSCS Cleanup - style cleanup for Launch Instance Configuration Step
Addressed by: https:/
JSCS Cleanup - style cleanup for Launch Instance Network Step
Addressed by: https:/
JSCS Cleanup - style cleanup for Launch Instance Security Groups Step
Addressed by: https:/
JSCS Cleanup - style guide cleanup for Keypair step
Addressed by: https:/
JSCS Cleanup - style cleanup for Launch Instance Source Step
Gerrit topic: https:/
Addressed by: https:/
JSCS cleanup - style guide cleanup for karma.config.js files
Addressed by: https:/
JSCS cleanup - openstack_
Addressed by: https:/
Switched from JSCS to ESLint
Addressed by: https:/
Add selective ESLint rule activation for Horizon Legacy JS
Addressed by: https:/
Removed JSHint
Addressed by: https:/
JSCS Cleanup - style cleanup for modal factory
Addressed by: https:/
JSCS cleanup - launch-instance.js
Addressed by: https:/
JSCS Cleanup - style guide cleanup for Util > Bind Scope
Addressed by: https:/
JSCS Cleanup - rename *.factory.js to *.service.js
Gerrit topic: https:/
Addressed by: https:/
Fix eslint errors on the login controller
Addressed by: https:/
Fix eslint errors about ng-di on the cloud-services.
Addressed by: https:/
Use angular.isUndefined in place of !angular.isDefined
Addressed by: https:/
JSCS - making app.module.js following JP
Addressed by: https:/
Ignore the ng_on_watch error from eslint
Addressed by: https:/
Change this to be set to 'vm' instead of 'ctrl' for soure.controller and source-
Addressed by: https:/
Change a comparison with 'undefined' to use angular.
Addressed by: https:/
Use angular.
Addressed by: https:/
Disable angular/
Addressed by: https:/
JSCS Cleanup - horizon/ tech-debt
Addressed by: https:/
fix a couple lint errors in filters.js
Addressed by: https:/
Ignore the ESLINT controller as VM rule
Addressed by: https:/
Addresses camelcase variable names and exceeded max-length violations
Addressed by: https:/
JSCS Cleanup - use DI in launch instance model
Addressed by: https:/
Fix eslint error on framework.module.
Addressed by: https:/
Fix eslint for the metadata-tree widgets.
Addressed by: https:/
JSCS Cleanup - use DI in launch instance model
Addressed by: https:/
Addresses use of digest in launch-instance specs by using apply instead
Addressed by: https:/
JSCS Cleanup - Include angular rules in eslint
Addressed by: https:/
JSCS Cleanup - rename vm as ctrl for login controller
Addressed by: https:/
JSCS Cleanup - use $apply instead of $digest for action-list.spec
Addressed by: https:/
JSCS Cleanup - Fix eslint errors in flavor
Addressed by: https:/
JSCS Cleanup - Fix eslint errors in source spec file
Addressed by: https:/
JSCS Cleanup - Fix eslint errors in workflow file
Addressed by: https:/
JSCS Cleanup - use function syntax for i18n
Addressed by: https:/
JSCS Cleanup - use $apply instead of $digest in help-panel spec
Addressed by: https:/
Fix eslint errors for hz.dashboard.
Gerrit topic: https:/
Addressed by: https:/
JSCS Cleanup - Metadata widgets cleanup
Addressed by: https:/
JSCS Cleanup - horizon widgets for transfer-table
Addressed by: https:/
JSCS Cleanup - horizon widgets for charts
Addressed by: https:/
JSCS Cleanup - horizon widgets for modal-wait-spinner
Addressed by: https:/
JSCS/eslint cleanup - o_s/tech-debt, bind-scope, toast
Addressed by: https:/
JSCS Cleanup - move functions humanize and truncate
Addressed by: https:/
JSCS Cleanup - style guide cleanup for configuration step
Addressed by: https:/
JSCS Cleanup - style guide cleanup for Flavor step
Addressed by: https:/
JSCS Cleanup - style guide cleanup for source step
Addressed by: https:/
JSCS Cleanup - style guide cleanup for security-groups step
Addressed by: https:/
JSCS Cleanup - style guide cleanup for Launch Instance wizard
Gerrit topic: https:/
Addressed by: https:/
JSCS cleanup - eslint cleanup for openstack-
Gerrit topic: https:/
Addressed by: https:/
JSCS Cleanup - use DI in launch instance model
Addressed by: https:/
Move magic_search.js in _scripts.html to after Angular files
Gerrit topic: https:/
Addressed by: https:/
Use the JP Style Guide for OpenStack Services
Addressed by: https:/
Upgraded eslint-
Gerrit topic: https:/
Gerrit topic: https:/
Addressed by: https:/
JSCS Cleanup - use DI in launch instance model
Addressed by: https:/
Fix eslint errors
Gerrit topic: https:/
Addressed by: https:/
Fix lint errors for horizon.
