All Horizon Look and Feel css should be moved into the default theme
There are a number of hard coded variables still sprinkled through the css that will prevent a seemless transition from the standard Horizon Default theme into other Bootstrap themes. These hard coded variables should derive from Bootstrap variables so that the overall look and feel will inherit from the theme. Also, many look-and-feel css elements are very Horizon theme specific (changes to dropdowns, tables, etc) and should be moved into the default theme as well. This will be a very large effort that will be spread across multiple small reviews. Initial research into this task has been done here: https:/
Blueprint information
- Status:
- Complete
- Approver:
- David Lyle
- Priority:
- High
- Drafter:
- Diana Whitten
- Direction:
- Approved
- Assignee:
- Diana Whitten
- Definition:
- Approved
- Series goal:
- None
- Implementation:
-
Implemented
- Milestone target:
- None
- Started by
- Diana Whitten
- Completed by
- Rob Cresswell
Related branches
Related bugs
| Bug #1195814: clean up meaningless css classes added to row actions | Won't Fix |
| Bug #1477292: launch instance step scss references ng controller | Invalid |
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Reorganization of Default Themes
Gerrit topic: https:/
Addressed by: https:/
Move the favicon.ico, logo.png and logo-splash.png files to the custom/default/img directory and therefore allow them to be overridden when using a custom theme.
Addressed by: https:/
XStatic Libraries should auto discover
Addressed by: https:/
Horizon Themes should support and house easy Template Overrides
Addressed by: https:/
Themeing Mechanism now supports 3rd party themes
Addressed by: https:/
Theming Mechanism now supports 3rd party themes
Addressed by: https:/
Themes should live at root of openstack_dashboard
Addressed by: https:/
Create a Bootstrap Theme Preview Page with HTML Hints
Addressed by: https:/
Top Nav is responsive and inherits from its theme
Addressed by: https:/
Sidebar now inherits from a Bootstrap Theme
Addressed by: https:/
Basic tables now inherit from Bootstrap Theme
Addressed by: https:/
Pie Charts now inherit from Bootstrap Theme
Addressed by: https:/
Horizon styles should use vendor prefix mixins
Addressed by: https:/
Horizon Login now inherits from Bootstrap Theme
Gerrit topic: https:/
Gerrit topic: https:/
Addressed by: https:/
Dropdowns should have a consistent design
Addressed by: https:/
Horizon Dropdown now inherits from Bootstrap Theme
Addressed by: https:/
Magic Search is now themable
Addressed by: https:/
New Theme Work Needs Better Documentation
Addressed by: https:/
Barcharts now inherit from a Bootstrap Theme
Addressed by: https:/
Basic Tabs now inherit from a Bootstrap Theme
Addressed by: https:/
Remove Unneeded Assets
Addressed by: https:/
Move Page Layout Styles out of horizon.scss
Addressed by: https:/
Horizon Messages now inherit from a Bootstrap Theme
Addressed by: https:/
usage.html doesn't need such specific styles.
Gerrit topic: https:/
Addressed by: https:/
Quota pages now inherit from Bootstrap Theme
Addressed by: https:/
Add Magic Search Filtering to NG Flavors
Gerrit topic: https:/
Addressed by: https:/
Horizon Checkboxes are now themeable.
Addressed by: https:/
Clean up horizon.scss
Addressed by: https:/
Clean up horizon.scss
Addressed by: https:/
Clean up horizon.scss - Flavor Table
Addressed by: https:/
Clean up horizon.scss - _contrib.scss
Addressed by: https:/
Clean up horizon.scss - _debt.scss
Addressed by: https:/
Clean up horizon.scss - _hacks.scss
Addressed by: https:/
Clean up horizon.scss - _layout.scss
Addressed by: https:/
Clean up horizon.scss - _legacy.scss
Addressed by: https:/
Clean up horizon.scss - _util.scss
Addressed by: https:/
Clean up horizon.scss - _datepicker.scss
Addressed by: https:/
Clean up horizon.scss - _membership.scss
Addressed by: https:/
Clean up horizon.scss - _modals.scss
Addressed by: https:/
Clean up horizon.scss - _resource_
Addressed by: https:/
Clean up horizon.scss - _tables.scss
Addressed by: https:/
Clean up horizon.scss - serial_console.scss
Addressed by: https:/
Clean up horizon.scss - default/
Addressed by: https:/
Clean up horizon.scss - default/
Addressed by: https:/
Clean up horizon.scss - default/
Addressed by: https:/
Clean up horizon.scss - Organize Imports
Addressed by: https:/
Horizon select-inputs are now themable
Addressed by: https:/
Clarify the themeing documentation
Addressed by: https:/
WIP Themeable loader/progress bar for tables
Addressed by: https:/
Remove table search placeholder overwrite
Addressed by: https:/
Container Loader Image now Themable
Addressed by: https:/
Horizon Radio Buttons are now themeable.
Gerrit topic: https:/
Gerrit topic: https:/
Gerrit topic: https:/
Gerrit topic: https:/
Addressed by: https:/
Hamburger navigation now sits above containers
Addressed by: https:/
Horizon selects are now themable: Table Actions
Addressed by: https:/
Horizon selects are now themable: Launch Instance
Addressed by: https:/
Horizon selects are now themable: Admin Hypervisors
Addressed by: https:/
Initial Clean Up Old CSS Styles in _debt.scss
Addressed by: https:/
Draggable Network Lists are now Themable
Addressed by: https:/
Legacy Transfer Table is now themable.
Gerrit topic: https:/
Addressed by: https:/
Horizon Spinner/Loader should inherit from theme
Addressed by: https:/
In integration tests prevent getting volume size too early
Addressed by: https:/
Horizon selects are now themable: Identity Panels
Gerrit topic: https:/
Gerrit topic: https:/
Addressed by: https:/
Horizon selects are now themable: Project Panels
Addressed by: https:/
Horizon selects are now themable: DynamicTypedCho
[robcresswell 2017-02-21]
Marking complete as the original intent has been mostly met. Future improvements, if anyone picks up this work, can be in a new blueprint or wishlist bugs.
