Configurable Selectors in Integration Tests
Horizon's integration tests are written assuming the default theme is being used. Other themes might have a different structure of the underlying HTML, and would require modifying the selectors used in the tests to make them work properly. This proposes to make those selectors configurable in the local-horizon.conf file, so that the integration tests can be run with a non-default theme as well.
For example, in regions/bars.py the TopBarRegion class has selectors that assume the user drop-down menu is on the right hand side: _user_dropdown_
Blueprint information
- Status:
- Complete
- Approver:
- None
- Priority:
- Undefined
- Drafter:
- Radomir Dopieralski
- Direction:
- Needs approval
- Assignee:
- Radomir Dopieralski
- Definition:
- Obsolete
- Series goal:
- None
- Implementation:
- Unknown
- Milestone target:
- None
- Started by
- Completed by
- Radomir Dopieralski
Related branches
Related bugs
Sprints
Whiteboard
Turns out that the changes necessary to make other themes work are too complex to put them in the config easily. We are just doing a patch on top of the upstream repository instead.