Reduce number of flake/pep8 ignored rules.
Heat tox.ini has several ignored flake/pep8 rules. To make code more clean would be better to reduce it's numbers
F841 local variable 'json_template' is assigned to but never used
H201 no 'except:' at least use 'except Exception:'
H302 import only modules.'bla..' does not import a module
H306 imports not in alphabetical order
H404 multi line docstring should start with a summary
First step - H201:
heat/db/
except:
^
heat/db/
except:
^
heat/engine/
except:
^
heat/engine/
except:
^
heat/engine/
heat/engine/
except:
^
heat/engine/
except:
^
heat/engine/
except:
^
heat/tests/
except:
^
heat/tests/
except:
^
heat/tests/
except:
Blueprint information
- Status:
- Complete
- Approver:
- Steve Baker
- Priority:
- Undefined
- Drafter:
- None
- Direction:
- Approved
- Assignee:
- Pavlo Shchelokovskyy
- Definition:
- Approved
- Series goal:
- None
- Implementation:
- Implemented
- Milestone target:
- 2014.2.2
- Started by
- Denis M.
- Completed by
- Angus Salkeld
Related branches
Related bugs
Sprints
Whiteboard
(stevebaker) Please enable each rule in a separate git change. You should expect push-back on some rules from reviewers, possibly with -2s. H201 will require some very careful testing. H404 has been rejected in the past. There are times where being able to do F841 is useful.
Gerrit topic: https:/
Addressed by: https:/
Order imports in alphabetical order (1/9)
Addressed by: https:/
Order imports in alphabetical order (2/9)
Addressed by: https:/
Order imports in alphabetical order (3/9)
Addressed by: https:/
Order imports in alphabetical order (4/9)
Addressed by: https:/
Order imports in alphabetical order (5/9)
Addressed by: https:/
Order imports in alphabetical order (6/9)
Addressed by: https:/
Order imports in alphabetical order (7/9)
Addressed by: https:/
Order imports in alphabetical order (8/9)
Addressed by: https:/
Update common docstrings to match guidelines
Addressed by: https:/
Update contrib docstrings to match guidelines
Addressed by: https:/
Order imports in alphabetical order (9/9)
Gerrit topic: https:/
Addressed by: https:/
Fix H201 violations and re-enable gating
(pshchelo) As this is in principle a never-ending topic :) I propose to close this blueprint as the number of ignored rules is clearly reduced already down to only 3 non-code related ones [1]. Whe moved to the newer "hacking" checks (with more and better checks), and currenlty ignore only 2 checks about multiline docstring formatting, and one about the commit message formatting, the code itself is completely checked.
[1] https:/