Models should be the same as the state in DB after migration
We are using declarative_base in heat.db.
For creation we are using migrations.
We don't have any tests that checks, that our models are up-to-date. Also we are testing it only on sqlite, which couldn't test such things as nullable constraints.
So We should:
1) Use always explicit nullable parameter for columns. There is a lot of mistakes in current heat models implementation. (sometimes in schema is nullable=True and in model nullable=False and vise versa). Also at this moment when you see Column description without nullable, you couldn't be sure that is author forget to set nullable='False' or it is really nullable='True'. So the easiest way to track all this and to fix and to avoid such things is to have one rule "always use explicit nullable".
2) Add in __table_args__ indexes and unique constraints
3) Fix all mistakes in models
4) Fix all mistakes in migrations
5) Sync effects of migrations in different backends.
6) Add tests that ensures that models are up-to-date.
This will allow us to find probably some mistake, or missing indexes and make work with db more clean.
Blueprint information
- Status:
- Complete
- Approver:
- Steven Hardy
- Priority:
- Undefined
- Drafter:
- Alexander Gordeev
- Direction:
- Approved
- Assignee:
- Alexander Gordeev
- Definition:
- Approved
- Series goal:
- None
- Implementation:
- Implemented
- Milestone target:
- None
- Started by
- Alexander Gordeev
- Completed by
- Steven Hardy
Related branches
Related bugs
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Add testing of migration from oslo
Addressed by: https:/
Fix sqlalchemy models
Addressed by: https:/
Fix sqlalchemy migrations
Addressed by: https:/
Add initial test for db migrations
(stevebaker) is this blueprint still valid?
(stevebaker) Moving to i-3. I still don't know if this blueprint should remain open, be mark Implemented, or Obsoleted.
Addressed by: https:/
Alter models and add migration
Addressed by: https:/
Add ModelSMigrationSync classes
This should be marked as implemented -- viktors