Converge to OpenStack Javascript Coding Standart
Fuel UI used to use independent eslint config to lint JavaScript code. Since Fuel in a part of OpenStack, we must use OpenStack coding style. As file http://
Here is a current list of disabled checks which needs to be enabled:
complexity: 0
eqeqeq: 0
no-script-url: 0
indent: [0, 2, {SwitchCase: 1}]
one-var: [0, {uninitialized: always, initialized: never}]
max-len: [0, 120]
Here is the list of disabled checks which are preferred to be kept disabled, but that can be discussed:
no-empty: 0 # we use empty blocks with try-catch
no-
consistent-
curly: 0 # we're ok with one-line if
operator-
no-
no-undefined: 0 # we're ok with using undefined
no-process-env: 0 # we use it in a few places and are ok with it
no-sync: 0 # it affects our browser code with Sync in function names, like "onModelSync"
Blueprint information
- Status:
- Complete
- Approver:
- Vitaly Kramskikh
- Priority:
- High
- Drafter:
- Vitaly Kramskikh
- Direction:
- Approved
- Assignee:
- Vitaly Kramskikh
- Definition:
- Approved
- Series goal:
- Accepted for mitaka
- Implementation:
-
Implemented
- Milestone target:
-
9.0
- Started by
- Vitaly Kramskikh
- Completed by
- Vitaly Kramskikh
Related branches
Related bugs
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Force eqeqeq eslint rule
Addressed by: https:/
Use 2 spaces instead of 4 for indentation of JS code
Addressed by: https:/
Enable linting for node.js files and split .eslintrc
Addressed by: https:/
Force no-script-url eslint rule
Addressed by: https:/
Eslint complexity rule
Gerrit topic: https:/
Addressed by: https:/
Force eslint one-var rule
Addressed by: https:/
Forcing eslint max-len rule
Addressed by: https:/
Enable 'consistent-return' eslint rule
Addressed by: https:/
Enable 'no-sync' eslint rule
Addressed by: https:/
Fix complexity warning for network validation code
Addressed by: https:/
Spec for converge-
Addressed by: https:/
Fix complexity warning for node pop-up
Addressed by: https:/
Force eqeqeq rule for test files
Addressed by: https:/
Force eqeqeq rule for plugin files
Addressed by: https:/
Force eqeqeq rule for cluster tab views
Addressed by: https:/
Force eqeqeq eslint rule for views
Addressed by: https:/
Fix complexity warning for node pop-up render
Addressed by: https:/
Force eqeqeq eslint rule for Fuel UI code
Addressed by: https:/
Fix missing eqeqeq in wizard code
Addressed by: https:/
Set ESLint 'curly' rule in 'multi-line' mode
Addressed by: https:/
Fix complexity warning for network validation
Addressed by: https:/
Restore missing quote-props ESLint rule
