Fluidity

Fix test_advection_diffusion

Registered by Graham Markall

test_advection_diffusion is currently broken since tensor fields were changed to support non-square tensors (quite some time). It should be fixed, and some tests made to prevent it getting broken and left again.

Blueprint information

Status:
Not started
Approver:
None
Priority:
Undefined
Drafter:
Graham Markall
Direction:
Needs approval
Assignee:
Graham Markall
Definition:
New
Series goal:
None
Implementation:
Unknown
Milestone target:
None

Related branches

Sprints

Whiteboard

I suggest the following steps can be taken to fix test_advection_diffusion and make it easier to notice if it breaks again:

1. Fix test_advection_diffusion.F90 to work with the non-square tensor fields
2. Edit tools/Makefile.in to build test_advection_diffusion when make fltools is run.
3. Add test cases (e.g. tests/test_advection_diffusion/cdisk_adv_diff.xml) that test that test_advection_diffusion runs, and that the output is as expected (e.g. testing for conservation of the tracer).

This was being implemented in the ufl-input branch. However, since this contains other (unrelated) changes, I've created a separate branch, fix-test-advection-diffusion for making this changes instead.

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.
Edit subscription

Subscribers

No subscribers.