Comment 6 for bug 1416344

Fix has been committed in rev 1075. Thanks Roman for the catch.

On Thu, Feb 12, 2015 at 6:14 AM, Roman Tereshonkov <
<email address hidden>> wrote:

> The proposed solution will not work. It will fail for librasync >= 1.0.0.
> RS_MD4_SIG_MAGIC is a constant of the enumeration.
> So #ifdef RS_MD4_SIG_MAGIC is always false.
> The possible working solution could be based
> on RS_DEFAULT_STRONG_LEN which exists for
> librasync < 1.0.0 only.
>
> #ifdef RS_DEFAULT_STRONG_LEN
> sm->sig_job = rs_sig_begin((size_t)blocklen,
> (size_t)RS_DEFAULT_STRONG_LEN);
> #else /* librasync >= 1.0.0 */
> sm->sig_job = rs_sig_begin((size_t)blocklen,
> (size_t)8, RS_MD4_SIG_MAGIC);
> #endif
>
> --
> You received this bug notification because you are subscribed to
> Duplicity.
> https://bugs.launchpad.net/bugs/1416344
>
> Title:
> librsync 1.0.0 breaks duplicity/_librsyncmodule.c compilation
>
> Status in Duplicity - Bandwidth Efficient Encrypted Backup:
> Fix Committed
>
> Bug description:
> librsync version 1.0.0 changes rs_sig_begin function API as
> -rs_job_t *rs_sig_begin(size_t new_block_len, size_t strong_sum_len);
> +rs_job_t *rs_sig_begin(size_t new_block_len, size_t strong_sum_len,
> + rs_long_t sig_magic);
>
>
> This makes the problem to compile duplicity/_librsyncmodule.c file.
> It uses the old rs_sig_begin format:
> sm->sig_job = rs_sig_begin((size_t)blocklen,
> (size_t)RS_DEFAULT_STRONG_LEN);
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/duplicity/+bug/1416344/+subscriptions
>