Change the way custom colors are used in Dockbarx themes
Right now Dockbarx has one color that is used in themes which are configurable for users: "Active glow". The name is quite misleading. In 3d party themes it's used for mouse over just as often . What about having for example three custom colors (in the code just called color1, color2 and color3) that are named from the theme, in such a way that when you change theme, the names changes in the preference dialog? The colors used for the popup dialog should also be accessible for the theme, and their name should become changeable when dockbarx starts to support theming of the popup window.
Should there also be some way for themes to set default values for the colors?
Blueprint information
- Status:
- Complete
- Approver:
- None
- Priority:
- High
- Drafter:
- None
- Direction:
- Needs approval
- Assignee:
- Matias Särs
- Definition:
- Approved
- Series goal:
- None
- Implementation:
-
Implemented
- Milestone target:
- None
- Started by
- Matias Särs
- Completed by
- Matias Särs
Related branches
Related bugs
Sprints
Whiteboard
Alex: Great idea! I've been thinking about something like this for awhile.
The idea should work very well as you have it outlined. Three colors should be a good place to start. Currently the two major top-level nodes are <pixmaps> and <button_pixmaps>. Another element should be added between them called <theme_colors>, or something similar.
I don't think it's there yet, but very soon DockbarX is going to need a dedicated themes tab in the preferences. It would be great to have thumbnails, a description, a color-editor for using these colors, etc.
Just a random thought: Make the GTK theme's colors available to DockbarX's themes. Gnome DO does something like this. So have variables like "selected_
Matias: It became four colors (color5 - color8), eight with popup colors (color1 - color4). And there's a "icon_average" color as well, that gives the average or dominant color of the icon. gtk colors will come if I figure them out. Suggestion on how to do that is welcome.
