Comment 2 for bug 927795

Revision history for this message
Scott Moser (smoser) wrote :

Jeff,
 I took a look, and generally looks ok.
 2 things:
   a.) I'm guessing we should then add 'salt' to the cloud_config_modules list
   b.) I haven't checked the packages of salt, but generally installation of a package in debian is supposed to start the service. Thus, the 'check_call' to 'service start-minion start', would fail in an upstart world, where 'start' on an already started service will exit error.
  Ie:
     $ sudo service ssh start; echo $?
     start: Job is already running: ssh
    1

So, I'd like for that to either check if running and start if not, or somehow handle that case, so that if the packages did automatically start that daemon, you wouldn't cause failure of this cloud-config module even though everything was actually good.