Ubuntu
upstart package

upstart-socket-bridge doesn't support ipv6 sockets

Bug #942955 reported by Steve Langasek
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
upstart
Fix Committed
Undecided
Unassigned
upstart (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

Playing with upstart-socket-bridge to see if it's a solution for avoiding polling in the Ubuntu cups post-start (bug #855010), I find that the socket bridge only supports inet and unix sockets - it does not support inet6 sockets. As a result, it's impossible to use socket initialization for an ipv6 service... which nowadays should be approximately all services.

If we want socket initialization to be a viable option for services, ipv6 support is a must.

Related branches

lp:~kai-mast/upstart/ipv6 (Merged)
lp:~cameronnemo/upstart/ipv6
James Hunt: Approve
Diff: 202 lines (+92/-25)
3 files modified
ChangeLog (+16/-0)
extra/man/socket-event.7 (+10/-1)
extra/upstart-socket-bridge.c (+66/-24)
lp:upstart
Daniël Sonck: Approve
Diff: 18561 lines (+11017/-1183) (has conflicts)
73 files modified
.bzrignore (+4/-0)
ChangeLog (+365/-0)
Makefile.am (+1/-1)
NEWS (+35/-1)
TESTING.sessions (+289/-0)
conf/rc-sysinit.conf (+2/-0)
configure.ac (+7/-3)
contrib/bash_completion/upstart (+96/-36)
contrib/vim/syntax/upstart.vim (+61/-27)
dbus/Upstart.conf (+6/-36)
dbus/com.ubuntu.Upstart.xml (+7/-0)
dbus/upstart.h (+1/-1)
extra/Makefile.am (+125/-0)
extra/conf/upstart-socket-bridge.conf (+16/-0)
extra/conf/upstart-udev-bridge.conf (+16/-0)
extra/man/socket-event.7 (+92/-0)
extra/man/upstart-socket-bridge.8 (+47/-0)
extra/man/upstart-udev-bridge.8 (+57/-0)
extra/upstart-socket-bridge.c (+644/-0)
extra/upstart-udev-bridge.c (+310/-0)
init/Makefile.am (+12/-0)
init/conf.c (+504/-55)
init/conf.h (+45/-2)
init/control.c (+111/-19)
init/control.h (+19/-1)
init/environ.c (+0/-1)
init/environ.h (+0/-1)
init/event.c (+22/-0)
init/event.h (+6/-1)
init/event_operator.c (+59/-0)
init/event_operator.h (+8/-0)
init/job.c (+47/-3)
init/job.h (+4/-1)
init/job_class.c (+115/-67)
init/job_class.h (+62/-2)
init/job_process.c (+122/-14)
init/job_process.h (+5/-3)
init/main.c (+297/-134)
init/man/init.5 (+236/-48)
init/man/init.8 (+32/-4)
init/parse_conf.c (+6/-0)
init/parse_job.c (+21/-7)
init/parse_job.h (+4/-2)
init/paths.h (+75/-2)
init/session.c (+320/-0)
init/session.h (+89/-0)
init/tests/test_blocked.c (+4/-1)
init/tests/test_conf.c (+1310/-15)
init/tests/test_control.c (+15/-11)
init/tests/test_environ.c (+3/-1)
init/tests/test_event.c (+28/-25)
init/tests/test_event_operator.c (+3/-0)
init/tests/test_job.c (+71/-76)
init/tests/test_job_class.c (+56/-65)
init/tests/test_job_process.c (+34/-30)
init/tests/test_parse_conf.c (+3/-0)
init/tests/test_parse_job.c (+302/-260)
init/tests/test_process.c (+3/-0)
init/tests/test_system.c (+3/-0)
po/POTFILES.in (+2/-0)
po/upstart.pot (+352/-155)
scripts/Makefile.am (+25/-0)
scripts/init-checkconf.sh (+248/-0)
scripts/initctl2dot.py (+571/-0)
scripts/man/init-checkconf.8 (+73/-0)
scripts/man/initctl2dot.8 (+87/-0)
util/Makefile.am (+1/-1)
util/initctl.c (+1014/-17)
util/initctl.h (+458/-0)
util/man/initctl.8 (+207/-34)
util/reboot.c (+0/-1)
util/tests/test_initctl.c (+1189/-19)
util/tests/test_user_sessions.sh (+553/-0)
Steve Langasek (vorlon)
Changed in upstart (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Steve Langasek (vorlon)
Changed in upstart (Ubuntu):
assignee: nobody → James Hunt (jamesodhunt)
Revision history for this message
Kai Mast (kai-mast) wrote :

Just wondering. I am not familiar with the upstart codebase, but this seems rather trivial to fix. Where is the problem here?

Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: [Bug 942955] Re: upstart-socket-bridge doesn't support ipv6 sockets

On 31 December 2013 13:20, Kai Mast <email address hidden> wrote:
> Just wondering. I am not familiar with the upstart codebase, but this
> seems rather trivial to fix. Where is the problem here?
>

The whole upstart socket bridge is a single C file in the upstart codebase:

https://bazaar.launchpad.net/+branch/upstart/view/head:/extra/upstart-socket-bridge.c

As the rest of the code base it heavily uses libnih library. Some
introduction / documentation about that library can be found at:

http://people.canonical.com/~jhunt/presentations/uds-r/2012-10-31/upstart-development.pdf

http://libnih.la/

--
Regards,

Dimitri.

Revision history for this message
Kai Mast (kai-mast) wrote :

Thanks for the info Dimitri.
I looked at the code and still think this can be resolved by adding a case for AF_INET6 to both switches.

Sadly, I have no idea how to test/debug upstart. Otherwise, I would definitly give this a try...

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

@Kai Mast
According to /sys/socket.h definition:
http://unix.superglobalmegacorp.com/Net2/newsrc/sys/socket.h.html

there isn't AF_INET6 declarations.

In "Address families" section there are only:
#define AF_INET 2 /* internetwork: UDP, TCP, etc. */

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Latest sys/socket.h is described here:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/socket.h.html

And there are AF_INET6 declaration.
Sorry for cofusion.

Revision history for this message
Kai Mast (kai-mast) wrote :

The linked branch builds now. I cannot find any tests for upstart socket bride, so I don't really now how to verify it is working. Any help?

Btw, here is a good tutorial how to convert code to IPv6: http://uw714doc.sco.com/en/SDK_netapi/sockC.PortIPv4appIPv6.html

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

I look at your code and here is my remarks:
1. Line 335:
  char buffer[INET6_ADDRSTRLEN];
use nih_local. It shoul looks like:
  nih_local char buffer[INET6_ADDRSTRLEN];

2. Line 72, 73
  Add comment with description of the variables sin6_addr and sin_addr

3. Line 539-546
  Fix identation. You could follow Coding style section in HACKING file

4. Update ChangeLog file

5. Update man files (with additional examples of the IPv6 usage) in directory: extra/man/

Bartosz Kosiorek (gang65)
Changed in upstart:
status: New → In Progress
Revision history for this message
Cameron Norman (cameronnemo) wrote :

So I made those tweaks you recommended, Bartosz.

Kai, you should install Ubuntu in a VM, install your Upstart branch from source, then write job that uses IPv6.

Revision history for this message
Kai Mast (kai-mast) wrote :

Thanks for picking this up cameron. Seem like you already tested it. Does it work?

Well, I was hoping there are some kind of unit tests for this.

James Hunt (jamesodhunt)
Changed in upstart (Ubuntu):
assignee: James Hunt (jamesodhunt) → nobody
Changed in upstart:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.