Tools should not recognize option prefixes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Invalid
|
Undecided
|
Unassigned |
Bug Description
I just noticed this:
pt-table-checksum --lock --help
Value "--help" invalid for option lock-wait-timeout (number expected)
It's recognizing --lock, which doesn't exist anymore, as the unambiguous prefix of --lock-
We need to disable this in the next release and include a warning. Otherwise we basically never can safely remove options and we'll have to be paranoid about introducing new options that create ambiguity about prefixes, e.g. right now, this will work:
pt-table-checksum --loc 1
it'll recognize that as --lock-
pt-table-checksum --recur 1
Option recur is ambiguous (recurse, recursion-method)
Usage: pt-table-checksum [OPTION...] [DSN]
Curse you, commandline option "smartness" :-(
tags: | added: all-tools |
Changed in percona-toolkit: | |
status: | New → Confirmed |
Changed in percona-toolkit: | |
milestone: | 2.0.4 → none |
Changed in percona-toolkit: | |
assignee: | nobody → Brian Fraser (fraserbn) |
assignee: | Brian Fraser (fraserbn) → Daniel Nichter (daniel-nichter) |
Hm.. I'm partially against this, since at least two people on #percona found it useful for the new pt-diskstats.
Seeing how it's not documented anywhere, we can reserve the right to yank it out at any time, but until it becomes an actual maintenance hurdle, I don't see why it should go away.