pt-heartbeat should use show slave status to determine master server-id in 5.5

Bug #923950 reported by Ryan Lowe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
New
Wishlist
Unassigned

Bug Description

As per the summary, the output of SHOW SLAVE STATUS includes the master server id, which should probably be used to get the value. This is especially helpful in 5.1->5.5 replication

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

It's a good question what the right default behavior is. Do you want to know the lag relative to the server's master, or to the master's master's master... what if the server is way down the replication chain? I think the best default behavior is to simply show the max lag relative to any of the masters.

Revision history for this message
Ryan Lowe (ryan-a-lowe) wrote :

That makes sense. Although the "default behavior" that I experience is "Cannot determine master server-id", so I guess my feature request would be "get the master server id from SHOW SLAVE STATUS if it cannot determine the master's server-id".

Revision history for this message
Baron Schwartz (baron-xaprb) wrote : Re: [Bug 923950] pt-heartbeat should use show slave status to determine master server-id in 5.5

Yes. As such, I feel this is a feature request, not a bug, and should be refiled as a blueprint.

Revision history for this message
Ryan Lowe (ryan-a-lowe) wrote :
tags: added: mysql-5.5 pt-heartbeat
Revision history for this message
Brian Fraser (fraserbn) wrote :

Marking as invalid since it has its own blueprint.

Changed in percona-toolkit:
importance: Undecided → Wishlist
status: New → Invalid
Revision history for this message
Matthew B (utdrmac) wrote :

Reopening this because the documentation clearly states:

"examines the replicated heartbeat record from its immediate master or the specified --master-server-id..."

Thus, this leaves one to believe, that in the case of simple Master->Slave replication, pt-heartbeat should grab the server_id from SHOW SLAVE STATUS.

Only if there is doubt, like Master_Server_Id NOT FOUND from SELECT * FROM heartbeat WHERE server_id = XX should the script abort with the error about not being able to determine masters id

Changed in percona-toolkit:
status: Invalid → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.