tar4ibd does not check for doublewrite buffer pages
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Medium
|
Alexey Kopytov |
Bug Description
The xtrabackup binary has the following code to skip checksum verification for doublewrite buffer pages:
"
#ifndef INNODB_
if (buf_page_
#else
if (buf_page_
#endif
{
if (
#ifdef XTRADB_BASED
#else
#endif
&& ((offset + (IB_INT64)
>= FSP_EXTENT_SIZE
&& ((offset + (IB_INT64)
< FSP_EXTENT_SIZE * 3) {
/* double write buffer may have old data in the end
or it may contain the other format page like COMPRESSED.
So, we can pass the check of double write buffer.*/
ut_a(page_size == UNIV_PAGE_SIZE);
fprintf(
"Page %lu seems double write "
"buffer. passing the check.\n",
thread_n,
(
"
However, tar4ibd does not have this check, so in case of checksum mismatch for such pages, tar4ibd would fail whereas xtrabackup would succeed with a warning.
Related branches
- Stewart Smith: Pending requested
-
Diff: 649 lines (+318/-66)2 files modifiedpatches/tar4ibd_libtar-1.2.11.patch (+236/-66)
test/t/bug810269.sh (+82/-0)
- Stewart Smith: Pending requested
-
Diff: 649 lines (+318/-66)2 files modifiedpatches/tar4ibd_libtar-1.2.11.patch (+236/-66)
test/t/bug810269.sh (+82/-0)
Changed in percona-xtrabackup: | |
status: | In Progress → Fix Released |
Is only applicable to 1.6, since tar4ibd is going to be removed in 1.7