OpenLP

"Update service from song edit" does work "too much"

Bug #772523 reported by Andreas Preikschat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Low
Tim Bentley
OpenLP 1.9.8 "Hopeful Hosea"

Bug Description

Hello,

xubuntu 10.10 trunk 1495

The setting "Update service from song edit" is disabled.

1) Add a song to the service
2.1) Edit the song in the Media Manager
Result:
Song in the Service Manger will be updated.

1) Add a song to the service
2.2) Edit the song in the Service Manager
Result:
Song in the Media Manager will be updated.

Expected result:
The song(s) should not be updated (neither in the Service Manager nor in the Media Manager).

Related branches

lp:~trb143/openlp/bug-772523
Raoul Snyman: Approve
Andreas Preikschat: Pending requested
Diff: 349 lines (+91/-21)
11 files modified
openlp/core/lib/db.py (+8/-1)
openlp/core/lib/eventreceiver.py (+4/-0)
openlp/core/lib/serviceitem.py (+2/-0)
openlp/core/ui/maindisplay.py (+2/-2)
openlp/core/ui/servicemanager.py (+25/-6)
openlp/plugins/songs/forms/songexportform.py (+3/-0)
openlp/plugins/songs/lib/db.py (+2/-1)
openlp/plugins/songs/lib/mediaitem.py (+15/-3)
openlp/plugins/songs/lib/upgrade.py (+12/-1)
openlp/plugins/songs/lib/xml.py (+6/-7)
openlp/plugins/songs/songsplugin.py (+12/-0)
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Note, editing media item song didn't seem to update service song immediately. Going live on that song still showed the unedited version. However when I edited the song, it then showed the media manager version, not the service version

Changed in openlp:
status: New → Confirmed
Jonathan Corwin (j-corwin)
Changed in openlp:
importance: Undecided → Low
Revision history for this message
Tim Bentley (trb143) wrote :

This seems to be working as I would expect.

If you edit a song from the ServiceManager it is updated back in the service manager. There is no setting to stop this and this is the version in the MediaManager. Both ServiceManager and MediaManager version are in step.

The "Update service from song edit" setting stops songs edited in the MediaManager updating the servicemanager if they are present. This only works for edits which start in the MediaManager.

Revision history for this message
Jonathan Corwin (j-corwin) wrote :

It isn't possible to edit a service manager song which is (now) different to the media manager song.
So if the "Update service from song edit" setting is disabled, the link from the service song to the media manager song should be broken if the media manager version is changed, thereby disabling the "Edit" option of that song via the service manager.

Tim Bentley (trb143)
Changed in openlp:
milestone: 1.9.6 → 1.9.7
Revision history for this message
Tim Bentley (trb143) wrote :

To bigger change for simple fix

Changed in openlp:
milestone: 1.9.7 → 1.9.8
Tim Bentley (trb143)
Changed in openlp:
assignee: nobody → Tim Bentley (trb143)
Tim Bentley (trb143)
Changed in openlp:
status: Confirmed → In Progress
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.