innodb_lru_dump_restore.patch: Buffer pool dump may result in incomplete dump file
Bug #686392 reported by
Alexey Kopytov
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
George Ormond Lorch III | ||
| 5.1 |
Fix Released
|
Medium
|
George Ormond Lorch III | ||
| 5.5 |
Fix Released
|
Medium
|
George Ormond Lorch III | ||
Bug Description
Since the output file is simply overwritten when dumping the LRU list, we may end up with a partially written dump file in case of a crash, or when making a backup copy of it.
The more safe approach would be to dump to a temporary file first, and then rename it to the actual dump file.
Related branches
lp:~gl-az/percona-server/5.1-lru_dump_load_work
- Alexey Kopytov (community): Approve
-
Diff: 100 lines (+37/-3)1 file modifiedPercona-Server/storage/innodb_plugin/buf/buf0lru.c (+37/-3)
- Alexey Kopytov: Pending requested
- Diff: 4362715 lines (has conflicts)
lp:~gl-az/percona-server/5.5-lru_dump_load_work
- Alexey Kopytov (community): Approve
-
Diff: 103 lines (+39/-4)1 file modifiedPercona-Server/storage/innobase/buf/buf0lru.c (+39/-4)
| summary: |
- innodb_dump_restore.patch: Buffer pool dump may result in incomplete + innodb_lru_dump_restore.patch: Buffer pool dump may result in incomplete dump |
| summary: |
innodb_lru_dump_restore.patch: Buffer pool dump may result in incomplete - dump + dump file |
| Changed in percona-server: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Alexey Kopytov (akopytov) |
Revision history for this message
| Stewart Smith (stewart) wrote | #1 |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #2 |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #3 |
| Changed in percona-server: | |
| assignee: | Alexey Kopytov (akopytov) → George Ormond Lorch III (gl-az) |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #4 |
To post a comment you must log in.
What's the status of this bug? Is it in progress? Can we expect it for next 5.1 and 5.5 releases?