Launchpad itself

debian/control XB- fields not exported in PPAs

Bug #613468 reported by Michael Vogt
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Jelmer Vernooij
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

The main archive (and apt-ftparchive and friends) supports adding additional entries to the Package stanza via the XB- mechanism. E.g.

$ apt-cache show pytagsfs|grep Python
Python-Version: 2.6
in the debian/control file there is a line:
XB-Python-Version: ${python:Versions}

If I look at the PPA build of this package, e.g. here:
http://ppa.launchpad.net/pythoneers/py27stack5/ubuntu/dists/maverick/main/binary-i386/Packages
the Python-Version line is missing.

It would be great to support this feature.

Related branches

lp:~jelmer/launchpad/613468-xb-ppa
Jeroen T. Vermeulen (community): Approve (code)
Diff: 476 lines (+215/-25)
8 files modified
lib/lp/archiveuploader/dscfile.py (+15/-0)
lib/lp/archiveuploader/nascentuploadfile.py (+31/-0)
lib/lp/archiveuploader/tests/__init__.py (+8/-4)
lib/lp/archiveuploader/tests/test_changesfile.py (+2/-1)
lib/lp/archiveuploader/tests/test_nascentuploadfile.py (+48/-0)
lib/lp/soyuz/model/publishing.py (+9/-0)
lib/lp/soyuz/tests/test_publish_archive_indexes.py (+91/-12)
lib/lp/soyuz/tests/test_publishing.py (+11/-8)
lp:~jelmer/launchpad/613468-xb-ppa-qa
Abel Deuring (community): Approve (code)
Diff: 780 lines (+138/-112)
16 files modified
lib/lp/archiveuploader/changesfile.py (+20/-20)
lib/lp/archiveuploader/dscfile.py (+37/-36)
lib/lp/archiveuploader/nascentuploadfile.py (+4/-3)
lib/lp/archiveuploader/tagfiles.py (+14/-7)
lib/lp/archiveuploader/tests/nascentupload-closing-bugs.txt (+1/-1)
lib/lp/archiveuploader/tests/nascentuploadfile.txt (+2/-2)
lib/lp/archiveuploader/tests/test_nascentuploadfile.py (+15/-1)
lib/lp/archiveuploader/tests/test_tagfiles.py (+4/-4)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+2/-2)
lib/lp/soyuz/doc/soyuz-upload.txt (+4/-4)
lib/lp/soyuz/model/queue.py (+14/-14)
lib/lp/soyuz/scripts/gina/handlers.py (+3/-0)
lib/lp/soyuz/scripts/processaccepted.py (+1/-1)
lib/lp/soyuz/scripts/tests/test_queue.py (+2/-2)
lib/lp/soyuz/scripts/tests/test_sync_source.py (+14/-14)
scripts/ftpmaster-tools/sync-source.py (+1/-1)
Revision history for this message
Michael Vogt (mvo) wrote :

See also:
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7

Revision history for this message
Michael Vogt (mvo) wrote :

The use case for this was to add additional metadata into the Packages file (like AppName, Categories, Iconname) until we get more support for metadata.

Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → Low
tags: added: soyuz-publish
tags: added: ppa
Revision history for this message
Michael Vogt (mvo) wrote :

I just noticed that in my use-case I was not specific enough. For the ubuntu spec:
https://blueprints.edge.launchpad.net/ubuntu/+spec/desktop-maverick-opportunistic-apps-stable-release
the ability to annotate the packages with additional (text)data is important (the ability to upload individual
additional files is great and we use it for the icons, but its not ideal for small textual data like AppName,
Categories).

Julian Edwards (julian-edwards)
tags: added: software-center
Jelmer Vernooij (jelmer)
Changed in soyuz:
assignee: nobody → Jelmer Vernooij (jelmer)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in db-stable r9651 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9651) by a commit, but not testable.

tags: added: qa-untestable
Ursula Junque (ursinha)
Changed in soyuz:
status: Triaged → Fix Committed
milestone: none → 10.09
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r9676 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9676>.

tags: added: qa-needstesting
removed: qa-untestable
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

QA'ed. This works, but because of the way DSCFiles are parsed all of the custom header field names get lowercased. I'll look into it.

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Jelmer, it appears that the lowercasing has been fixed on dogfood now. Is that correct? My test package has built in my PPA on dogfood.lp.net and the custom fields look correct there:

  http://ppa.dogfood.launchpad.net/gary-lasker/ppa/ubuntu/dists/maverick/main/binary-i386/Packages

That looks just right to me.

Thanks!

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Ah yes, I see that it looks to have been fixed in your recent branch lp:~jelmer/launchpad/613468-xb-ppa-qa. Sweet, thanks a lot! I'm testing with it now.

Revision history for this message
Ursula Junque (ursinha) wrote :

Hi Jelmer, is this qa-bad due to the lowercasing problem, qa-ok, or still needs to be tested?

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 613468] Re: debian/control XB- fields not exported in PPAs

Hi Ursula,

On Tue, 2010-08-31 at 02:33 +0000, Ursula Junque wrote:
> Hi Jelmer, is this qa-bad due to the lowercasing problem, qa-ok, or
> still needs to be tested?
 Yep, it works apart from the lowercasing problem, for which I have a fix in progress (it's been approved but not yet landed).

Jelmer Vernooij (jelmer)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in db-stable r9741 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9741>.

tags: added: qa-needstesting
removed: qa-ok
Jelmer Vernooij (jelmer)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
Revision history for this message
Gary Lasker (gary-lasker) wrote :

I just wanted to check in to say that I tested the newly-deployed metadata capability today with a test package in the app-review-board PPA and everything worked perfectly. This is really great as it is a big step in the implementation of https://blueprints.edge.launchpad.net/ubuntu/+spec/desktop-maverick-opportunistic-apps-stable-release.

Thanks very much to Jelmer and to everyone else who helped to make this happen! :D

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.