LoCo Team Portal

LD does not deal well with renamed teams

Bug #582354 reported by Dan Trevino
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
LoCo Team Portal
Fix Released
High
Daniel Holbach
LoCo Team Portal 0.2.20

Bug Description

"Ubuntu Washington LoCo", "Ubuntu Saudi Arabia LoCo Team" and "Thai Loco Team" are duplicated in the team listing

Tags: teams data ui

Related branches

lp:~dholbach/loco-team-portal/582354
Chris Johnston: Approve
Diff: 351 lines (+242/-4)
10 files modified
loco_directory/teams/forms.py (+2/-2)
loco_directory/teams/management/commands/lpupdate.py (+9/-0)
loco_directory/teams/migrations/0010_add_photos_feed_fields.py (+2/-2)
loco_directory/teams/migrations/0011_add_team_active.py (+116/-0)
loco_directory/teams/models.py (+1/-0)
loco_directory/teams/urls.py (+2/-0)
loco_directory/teams/views.py (+48/-0)
loco_directory/templates/teams/merge_teams.html (+24/-0)
loco_directory/templates/teams/select_other_team.html (+37/-0)
loco_directory/templates/teams/team_detail.html (+1/-0)
Revision history for this message
Chris Johnston (cjohnston) wrote :

Washington has two LP teams according to LoCo dir:

ubuntu-washington and washingtonstate - ubuntu-washington looks to be correct

Thai has thai-locoteam and ubuntu-th - ubuntu-th looks to be correct.

Saudi Arabia is ubuntu-sa-loco and ubuntu-sa with ubuntu-sa looking correct.

Changed in loco-directory:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → Medium
Revision history for this message
Daniel Holbach (dholbach) wrote :

Do those teams still exist? Are they all part of ~locoteams or ~locoteams-approved?

Revision history for this message
Chris Johnston (cjohnston) wrote : Re: [Bug 582354] Re: teams duplicated in listing

When you click the link to the team from loco dir to lp it gives a
page not found.

Revision history for this message
Chris Johnston (cjohnston) wrote : Re: teams duplicated in listing

Also can add dcteam vs ubuntu-districtofcolumbia to the list.

Revision history for this message
Daniel Holbach (dholbach) wrote :

In those cases the teams were renamed in Launchpad. :-(

We need to check in lpupdate if they still exist. This sucks. We will have to remove all data attached to teams that were renamed. (events, etc.)

Revision history for this message
Daniel Holbach (dholbach) wrote :

The decision is to:

 - add a "delete team" button for admins and owners of the old team (that's deleted in LP)
 - ask for the id of a new team, and only if they're admin/owner of the new team too, old events get reassigned
 - delete team

tags: added: data teams ui
Revision history for this message
Daniel Holbach (dholbach) wrote :

From bug 589519: "It's no longer ~dcteam but instead ~ubuntu-districtofcolumbia".

Daniel Holbach (dholbach)
Changed in loco-directory:
importance: Medium → High
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Yep, the problem began with my team when I changed its name from ~ubuntu-sa-loco to just ~ubuntu-sa .
Perhaps this problem will be fixed if I leave and then re-join the ~locoteams team.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

But I am not going to do that ^^

Revision history for this message
Daniel Holbach (dholbach) wrote :

Bilal: don't worry - it's a bug in LoCo Directory we need to fix.

Revision history for this message
Michael Hall (mhall119) wrote :

If we can get some kind of permanent UID from launchpad, then we could handle the renames without adding new teams, and there would be no need for functionality to transition from one record to another.

Daniel Holbach (dholbach)
summary: - teams duplicated in listing
+ LD does not deal well with renamed teams
Revision history for this message
Laura Czajkowski (czajkowski) wrote :

We seem to have two Thai teams also

http://loco.ubuntu.com/teams/ubuntu-th
http://loco.ubuntu.com/teams/thai-locoteam

Daniel Holbach (dholbach)
Changed in loco-directory:
assignee: nobody → Daniel Holbach (dholbach)
status: Triaged → In Progress
Daniel Holbach (dholbach)
Changed in loco-directory:
milestone: none → 0.2.20
status: In Progress → Fix Committed
Chris Johnston (cjohnston)
Changed in loco-directory:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.