Allow team as team owner/admin
Bug #474130 reported by
Daniel Holbach
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| LoCo Team Portal |
Fix Released
|
High
|
Daniel Holbach | ||
Bug Description
A common setup is like this one: ~ubuntu-cl has ~ubuntu-cl-concilio as owner. LoCo Directory does not recursively check team membership when allowing team info changes.
Related branches
lp:~dholbach/loco-team-portal/fix474130
- Efrain Valles: Approve
-
Diff: 71 lines (+22/-10)4 files modifiedloco_directory/common/launchpad.py (+19/-0)
loco_directory/common/utils.py (+0/-7)
loco_directory/teams/management/commands/lpupdate.py (+1/-1)
loco_directory/teams/views.py (+2/-2)
lp:~dholbach/loco-team-portal/fix-acl-checks
- Efrain Valles: Approve
-
Diff: 81 lines (+37/-8)3 files modifiedloco_directory/common/launchpad.py (+8/-7)
loco_directory/teams/tests.py (+28/-0)
loco_directory/teams/views.py (+1/-1)
| Changed in loco-directory: | |
| importance: | Undecided → High |
| milestone: | none → 0.1.1 |
| status: | New → Triaged |
| Changed in loco-directory: | |
| milestone: | 0.1.1 → 0.1.0 |
| assignee: | nobody → Daniel Holbach (dholbach) |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #1 |
| Changed in loco-directory: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #2 |
| Changed in loco-directory: | |
| status: | Fix Committed → Triaged |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #3 |
| Changed in loco-directory: | |
| status: | Triaged → Fix Committed |
| Changed in loco-directory: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #4 |
| Changed in loco-directory: | |
| status: | Fix Released → Triaged |
| Changed in loco-directory: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
I made it so that the team.owner is checked if it's a team. Let's ignore teams being admin for now, going through the list of members to find admins, then check if they're teams, then check if their members are the ones who want to edit or more sophisticated (more levels of recursion) are too slow.