zfs-initramfs needs to set FRAMEBUFFER=y

Bug #1856408 reported by Steve Langasek
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The poorly-named 'FRAMEBUFFER' option in initramfs-tools controls whether the console_setup and plymouth scripts are included and used in the initramfs. These are required for any initramfs which will be prompting for user input: console_setup because without it the user's configured keymap will not be set up, and plymouth because you are not guaranteed to have working video output in the initramfs without it (e.g. some nvidia+UEFI configurations with the default GRUB behavior).

The zfs initramfs script may need to prompt the user for passphrases for encrypted zfs datasets, and we don't know definitively whether this is the case or not at the time the initramfs is constructed (and it's difficult to dynamically populate initramfs config variables anyway), therefore the zfs-initramfs package should just set FRAMEBUFFER=yes in a conf snippet the same way that the cryptsetup-initramfs package does (/usr/share/initramfs-tools/conf-hooks.d/cryptsetup).

Tags: zfs
Revision history for this message
Richard Laager (rlaager) wrote :

Should it set KEYMAP=y too, like cryptsetup does?

I've created a PR upstream and done some light testing:
https://github.com/zfsonlinux/zfs/pull/9723

Are you able to confirm that this fixes the issue wherever you were seeing it?

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 1856408] Re: zfs-initramfs needs to set FRAMEBUFFER=y

On Sun, Dec 15, 2019 at 03:40:26AM -0000, Richard Laager wrote:
> Should it set KEYMAP=y too, like cryptsetup does?

KEYMAP is unused in Ubuntu, so this is harmless but unnecessary here. It's
possible something in Debian uses it.

> I've created a PR upstream and done some light testing:
> https://github.com/zfsonlinux/zfs/pull/9723

> Are you able to confirm that this fixes the issue wherever you were
> seeing it?

Confirmed that this works as expected on 19.10. Thanks!

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
<email address hidden> <email address hidden>

tags: added: zfs
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.8.2-3ubuntu4

---------------
zfs-linux (0.8.2-3ubuntu4) focal; urgency=medium

  * debian/patches/initramfs-setup-keymapping-and-video-for-
    prompts.patch: initramfs: setup keymapping and video for prompts.
    Thanks to Richard Laager <email address hidden>. Closes LP: #1856408.

 -- Steve Langasek <email address hidden> Mon, 16 Dec 2019 09:42:52 -0800

Changed in zfs-linux (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.