python-openstackclient

Rework for ``ip floating/fixed`` and ``ip floating pool`` commands

Bug #1555990 reported by Tang Chen on 2016-03-11

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	python-openstackclient	Fix Released	High	Tang Chen

Bug Description

"ip floating" is not a correct resource name. All the "ip floating delete/list/show/create" commands should be renamed to "floating ip xxx".

And also "ip fixed xxx" and "ip floating pool".

ip floating pool list -> floating ip pool list
ip fixed add -> server add fixed ip
ip fixed remove -> server remove fixed ip
ip floating add -> server add floating ip
ip floating remove -> server remove floating ip
ip floating * -> floating ip *

See original description

Tang Chen (tangchen) on 2016-03-11

Changed in python-openstackclient:
assignee:	nobody → Tang Chen (tangchen)

Revision history for this message

Richard Theis (rtheis) wrote on 2016-03-14:

Hi Tang, I think it may be best to track this work via a blueprint.

Revision history for this message

Richard Theis (rtheis) wrote on 2016-03-29:

Please consider https://bugs.launchpad.net/python-openstackclient/+bug/1476163 with this refactor.

Dean Troyer (dtroyer) on 2016-06-02

Changed in python-openstackclient:
importance:	Undecided → High

Tang Chen (tangchen) on 2016-06-16

summary:	- Refactor "ip floating xxx" commands to "floating ip xxx" + Rework for ``ip floating/fixed`` and ``ip floating pool`` commands
description:	updated

OpenStack Infra (hudson-openstack) on 2016-06-16

Changed in python-openstackclient:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-06: Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/300388
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=50bd56db258a16199463afcdeb2f0579384cc711
Submitter: Jenkins
Branch: master

commit 50bd56db258a16199463afcdeb2f0579384cc711
Author: Tang Chen <email address hidden>
Date: Fri Jun 17 14:39:13 2016 +0800

Transfer "ip floating pool list" to "floating ip pool list"

This patch does the following things to transfer
"ip floating pool list" to "floating ip pool list":

    * Add a new command "floating ip pool list" to deprecate
      "ip floating pool list". The source code is in network/v2
      dir.
    * Add doc for "floating ip pool list".
    * Add floating ip pool unit tests.

    Change-Id: Id410f4e4a96cf589a6e8def209574da71395b55f
    Implements: blueprint rework-ip-commands
    Partial-bug: 1555990
    Co-Authored-By: Dean Troyer <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-06:

Reviewed: https://review.openstack.org/302508
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d1f9ea3f750bb4c1f440ebfa93d06a40673ec0aa
Submitter: Jenkins
Branch: master

commit d1f9ea3f750bb4c1f440ebfa93d06a40673ec0aa
Author: Tang Chen <email address hidden>
Date: Thu Apr 7 14:10:37 2016 +0800

Transfer "ip floating add/remove" to "server add/remove
floating ip"

    This patch does the following things to transfer
    "ip floating add/remove" to "server add/remove floating ip":
    * Add new command "server add/remove floating ip", and unit
      tests and doc.
    * Deprecate "ip floating add/remove" command.

    compute/v2/floatingip.py is not removed because the arguments'
    positions are different between the new and old commands.
    * ip floating add <ip-address> <server>
      server add floating ip <server> <ip-address>
    * ip floating remove <ip-address> <server>
      server remove floating ip <server> <ip-address>

    Change-Id: Ic0dd22ca6fb7b7bc3e820fd5a14d7c551e7ab963
    Implements: blueprint rework-ip-commands
    Partial-bug: 1555990
    Co-Authored-By: Dean Troyer <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-06:

Reviewed: https://review.openstack.org/302590
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=179ebe6d648fc5cff514306076f1b0fa54e64b40
Submitter: Jenkins
Branch: master

commit 179ebe6d648fc5cff514306076f1b0fa54e64b40
Author: Tang Chen <email address hidden>
Date: Thu Apr 7 14:30:06 2016 +0800

Transfer "ip fixed add/remove" to "server add/remove fixed ip"

    This patch does the following things to transfer
    "ip fixed add/remove" to "server add/remove fixed ip":
    * Add new command "server add/remove fixed ip", and unit
      tests and doc.
    * Deprecate "ip fixed add/remove" command.

    compute/v2/fixedip.py is not removed because the arguments'
    positions are different between the new and old commands.
    * ip fixed add <network> <server>
      server add fixed ip <server> <network>
    * ip fixed remove <ip-address> <server>
      server remove fixed ip <server> <ip-address>

    Change-Id: Ica07ccf92a76c21fd5608ecaff86ff7c4d96f5a0
    Implements: blueprint rework-ip-commands
    Partial-bug: 1555990
    Co-Authored-By: Dean Troyer <email address hidden>

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-20:

Reviewed: https://review.openstack.org/302687
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=0aa2304f38da0696576827fc4d71f2cf7cc13ad6
Submitter: Jenkins
Branch: master

commit 0aa2304f38da0696576827fc4d71f2cf7cc13ad6
Author: Tang Chen <email address hidden>
Date: Fri Jun 17 15:06:40 2016 +0800

Transfer "ip floating CRUD" to "floating ip CRUD"

    This patch does the following things to transfer
    "ip floating xxx" to "floating ip xxx":
    * Add new command "floating ip create/delete/list/show", and doc.
    * Deprecate "ip floating create/delete/list/show" command.

    Change-Id: Ib071acaac81988431244e858bddafa7f93403df5
    Implements: blueprint rework-ip-commands
    Closes-bug: 1555990
    Co-Authored-By: Dean Troyer <email address hidden>