Percona Server moved to https://jira.percona.com/projects/PS

buf_dblwr_init_or_load_pages now returns an error code, but caller not updated

Bug #1549301 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Server
Unknown
Unknown
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.5
Invalid
Undecided
Unassigned
5.6
Invalid
Undecided
Unassigned
5.7
Fix Released
Low
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.7.11-4

Bug Description

Copy of http://bugs.mysql.com/bug.php?id=80496:

[24 Feb 14:00] Laurynas Biveinis
Description:
This is a minor code review type of bug:

buf_dblwr_init_or_load_pages, previously a void function, now returns a dberr_t since [1]. But its sole caller does not bother to check it.

[1]:

commit 98909cefbc37e54efc6452c7e95bccbf64ac9213
Author: Sunny Bains <email address hidden>
Date: Wed Mar 4 13:58:59 2015 +1100

    WL#7696 - Backport code from mysql-trunk to mysql-5.7

How to repeat:
Grep for buf_dblwr_init_or_load_pages

Suggested fix:
Check the return code in SysTablespace::read_lsn_and_check_flags, add attribute warn_unused_result.

Laurynas Biveinis (laurynas-biveinis)
tags: added: innodb low-hanging-fruit upstream
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

https://github.com/percona/percona-server/pull/377

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-3384

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.