Listing volumes respects osapi_max_limit but does not provide a link to the next element

IIUC all the items of the list (=N) can *only* be fetched if:

    "osapi_max_limit" >= N

and if N > "osapi_max_limit" then N - "osapi_max_limit" items get truncated. The code [1] has this section:

    def _get_collection_links(self,
                              request,
                              items,
                              collection_name,
                              id_key="uuid"):
        """Retrieve 'next' link, if applicable. This is included if:
        1) 'limit' param is specified and equals the number of items.
        2) 'limit' param is specified but it exceeds CONF.osapi_max_limit,
        in this case the number of items is CONF.osapi_max_limit.
        3) 'limit' param is NOT specified but the number of items is
        CONF.osapi_max_limit.
        """
        links = []
        max_items = min(
            int(request.params.get("limit", CONF.osapi_max_limit)),
            CONF.osapi_max_limit)
        if max_items and max_items == len(items):

The "==" confuses me, I would expect "<" here.

References:
[1] https://github.com/openstack/nova/blob/c857d791a2f127e63c20ae8380498ff67e76051b/nova/api/openstack/common.py#L471

Fix proposed to branch: master
Review: https://review.openstack.org/237999

Tempest will validate volume list response body.
It didn't accept unexpected attribute volumes_links.
We need to add volumes_links attribute in tempest first.

Fix proposed to branch: master
Review: https://review.openstack.org/245627

Fix proposed to branch: master
Review: https://review.openstack.org/255760

Change abandoned by lyanchih (<email address hidden>) on branch: master
Review: https://review.openstack.org/245627
Reason: Volume response had been move to tempest-lib repository

Related fix proposed to branch: master
Review: https://review.openstack.org/261896

Related fix proposed to branch: master
Review: https://review.openstack.org/261897

Related fix proposed to branch: master
Review: https://review.openstack.org/261898

Related fix proposed to branch: master
Review: https://review.openstack.org/261899

Related fix proposed to branch: master
Review: https://review.openstack.org/264114

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/264114
Reason: As mentioned, I am abandoning this spec to clear out the review queue ready for Newton. That said, feel free to restore this change with an updated version when you're ready to proceed.

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/237999
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.
If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.
If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

Also tagging as New. It is old and requires to be verified.

This seems like change in API and with version bump. Now nova proxy APIs are deprecated and so volume APIs [1]. IMO, there is no much benefit of enhancing the proxy APIs, it is recommended to use volume APIs instead.

.. 1 https://developer.openstack.org/api-ref/compute/#volume-extension-os-volumes-os-snapshots-deprecated

Tempest is verifying what current API return.

I am marking invalid for both nova and tempest as per APIs are deprecated now.

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/261899
Reason: Abandoning the change, feel free to propose the change on tempest repo if needed. Thanks.

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/261898
Reason: Abandoning the change, feel free to propose the change on tempest repo if needed. Thanks.

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/261897
Reason: Abandoning the change, feel free to propose the change on tempest repo if needed. Thanks.

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: master
Review: https://review.openstack.org/261896
Reason: Abandoning the change, feel free to propose the change on tempest repo if needed. Thanks.