amulet/openstack service checks need init system awareness
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
New
|
Undecided
|
Unassigned | ||
Bug Description
Amulet/openstack service check methods need series and init system awareness for testing Vivid and later.
I'm using the heat amulet test writing effort to also update charm-helpers to resolve this Vivid issue, and other general Wily prep.
Affected charm-helper pieces are:
[1] validate_services()
http://
[2] _get_openstack_
http://
This affects all openstack charm amulet tests, keystone as an example:
Previous approach presumes presence of upstart:
http://
http://
Once resolved and landed, other openstack charms can also have vivid/wily++ amulet tests.
Related branches
- Corey Bryant (community): Approve
- James Page: Pending requested
-
Diff: 481 lines (+227/-12)4 files modifiedcharmhelpers/contrib/amulet/utils.py (+91/-6)
charmhelpers/contrib/openstack/amulet/deployment.py (+6/-2)
charmhelpers/contrib/openstack/amulet/utils.py (+122/-3)
charmhelpers/contrib/openstack/utils.py (+8/-1)
- Corey Bryant (community): Approve
- OpenStack Charmers: Pending requested
-
Diff: 2349 lines (+2079/-59)24 files modifiedMakefile (+16/-12)
charm-helpers-tests.yaml (+5/-0)
hooks/charmhelpers/contrib/hahelpers/cluster.py (+12/-3)
hooks/charmhelpers/contrib/openstack/ip.py (+49/-44)
tests/00-setup (+11/-0)
tests/014-basic-precise-icehouse (+11/-0)
tests/015-basic-trusty-icehouse (+9/-0)
tests/016-basic-trusty-juno (+11/-0)
tests/017-basic-trusty-kilo (+11/-0)
tests/018-basic-utopic-juno (+9/-0)
tests/019-basic-vivid-kilo (+9/-0)
tests/README (+76/-0)
tests/basic_deployment.py (+606/-0)
tests/charmhelpers/__init__.py (+38/-0)
tests/charmhelpers/contrib/__init__.py (+15/-0)
tests/charmhelpers/contrib/amulet/__init__.py (+15/-0)
tests/charmhelpers/contrib/amulet/deployment.py (+93/-0)
tests/charmhelpers/contrib/amulet/utils.py (+408/-0)
tests/charmhelpers/contrib/openstack/__init__.py (+15/-0)
tests/charmhelpers/contrib/openstack/amulet/__init__.py (+15/-0)
tests/charmhelpers/contrib/openstack/amulet/deployment.py (+151/-0)
tests/charmhelpers/contrib/openstack/amulet/utils.py (+413/-0)
tests/files/hot_hello_world.yaml (+66/-0)
tests/tests.yaml (+15/-0)
