Support Launching an instance with a port with vnic_type=direct

Hi,
Can you please explain why do you consider it invalid?

My apologies; I think I must have misclicked during cleanup of multiple bugs.

https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking

 - Adding the ability to specify vnic_type to 'port create' operation

This is done and available on master already.

Fix proposed to branch: master
Review: https://review.openstack.org/253112

 - Adding the ability to launch an instance with a pre configured port

Should be converted into a BP IMO as its much bigger than a simple bug. Plus it needs to be done on both the old create instance and the new javascript one so it needs to be properly defined on how to show it, how would it work, what is expected and so on.

Added BP for the second part:
https://blueprints.launchpad.net/horizon/+spec/sriov-support

Added BP for the first part as well as this seems more in line with a new feature than a bug.

https://blueprints.launchpad.net/horizon/+spec/network-ports-tenant

https://blueprints.launchpad.net/horizon/+spec/sriov-support has been superseed.

Attaching ports to an instance on launch is not SR-IOV exclusive and actually has nothing to do with attaching ports or neutron or anything, its a configuration on nova + neutron which is left to the operator.

so first lets bring attaching ports to instance launch instead.
https://blueprints.launchpad.net/horizon/+spec/allow-launching-ports

Launching an instance with pre-created neutron port is already supported.
I think the remaining issue is to allow users (non-admin) to create a port by specifying vnic_type.

@Itxaka, are you still working on this? If not, could you clear the assignee?

@Akihiro not anymore, let me clear the assignee :)

Fix proposed to branch: master
Review: https://review.openstack.org/513887

Reviewed: https://review.openstack.org/513887
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=09efe2d432c7a17c696e7240f69b3c76b481e3f3
Submitter: Zuul
Branch: master

commit 09efe2d432c7a17c696e7240f69b3c76b481e3f3
Author: Akihiro Motoki <email address hidden>
Date: Sat Oct 21 00:48:42 2017 +0000

    Allow regular users to specify VNIC type for port

    VNIC type needs to be specified when creating a server with an SR-IOV
    port. In this case, a user first creates a port with vnic_type=direct
    and creates a server with the created port. To allow this scenario,
    horizon needs to allow users to specify VNIC type for port.

    This commit also clean up the code duplication on the port security and
    mac state fields in the port create form. The code in the admin form for
    them are completely duplicated with that in the project form.

    Change-Id: Ib6e91ed7f720e2720994025429da0dcef2fa4e25
    Closes-Bug: #1402959

This issue was fixed in the openstack/horizon 13.0.0.0b3 development milestone.