SQLAlchemy Storage Backend keeps stale / inconsistent data

Bug #1366107 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Wishlist
Federico Ceratto

Bug Description

When deleting a domain, we do not delete the recordsets for each zone at the same time.

This results in the recordsets table storing stale data as active.

This might also happen for records and recordsets.

Kiall Mac Innes (kiall)
Changed in designate:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Kiall Mac Innes (kiall) wrote :

When a domain is deleted, we currently mark it deleted = 0, the recordset/record data remains.

We currently don't have a deleted column on these tables, as keeping the data for a period of time after deletion has not been necessary. With the new zone-manager service coming in through the zone-exists-spec, we should add a new periodic task to issue a SQL DELETE for domains deleted over 24hr (config option ofc), which will cascade through to the recordsets/records etc.

tags: added: low-hanging-fruit
Revision history for this message
Kiall Mac Innes (kiall) wrote :

Err, we currently mark it deleted != 0..

Changed in designate:
assignee: nobody → pradeep kumar singh (pradeep-singh-u)
Revision history for this message
Kiall Mac Innes (kiall) wrote :

WIP spec https://review.openstack.org/#/c/207115/
WIP patch https://review.openstack.org/#/c/207959/

I had asked Federico to start working on this without realizing there was a bug for it.. Apologies!

Changed in designate:
milestone: none → liberty-3
assignee: Pradeep Kumar Singh (pradeep-singh-u) → Federico Ceratto (federico-ceratto)
status: Triaged → In Progress
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-3 → liberty-rc1
Kiall Mac Innes (kiall)
Changed in designate:
status: In Progress → Fix Committed
Kiall Mac Innes (kiall)
Changed in designate:
status: Fix Committed → Triaged
milestone: liberty-rc1 → none
Changed in designate:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.