Pushed list item remains highlighted even when releasing will do nothing
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
Bug Description
Ubuntu Trusty r188
1. Go to System Settings > "Language & Text".
2. Quickly tap the "Spell checking" list item.
3. Slowly push down on the "Spell checking" list item, then release after a few seconds.
What happens:
2. The item highlights and then returns to its previous appearance, and the switch toggles.
3. The item highlights and then returns to its previous appearance, but the switch does not toggle.
What should happen: either
3a. the item loses its highlight after the maximum tap duration, or
3b. there is no maximum tap duration, and the switch still toggles when you release (bug 1365471).
It is misleading to highlight a control as if it will change state, and then not do it.
(Not to be confused with bug 1362305, about items that don't do anything regardless of how long you tap them.)
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 4615 lines (+4323/-22)35 files modifiedcomponents.api (+57/-0)
documentation/overview.qdoc (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemPanel.qml (+180/-0)
modules/Ubuntu/Components/Themes/Ambiance/ListItemStyle.qml (+36/-0)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+4/-0)
modules/Ubuntu/Components/plugin/plugin.cpp (+13/-0)
modules/Ubuntu/Components/plugin/plugin.pro (+14/-2)
modules/Ubuntu/Components/plugin/propertychange_p.cpp (+76/-0)
modules/Ubuntu/Components/plugin/propertychange_p.h (+39/-0)
modules/Ubuntu/Components/plugin/quickutils.cpp (+23/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+1/-0)
modules/Ubuntu/Components/plugin/ucaction.h (+2/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+1260/-0)
modules/Ubuntu/Components/plugin/uclistitem.h (+126/-0)
modules/Ubuntu/Components/plugin/uclistitem_p.h (+202/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.cpp (+541/-0)
modules/Ubuntu/Components/plugin/uclistitemactions.h (+113/-0)
modules/Ubuntu/Components/plugin/uclistitemactions_p.h (+61/-0)
modules/Ubuntu/Components/plugin/uclistitemactionsattached.cpp (+247/-0)
modules/Ubuntu/Components/plugin/uclistitemattached.cpp (+207/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.cpp (+70/-0)
modules/Ubuntu/Components/plugin/uclistitemstyle.h (+53/-0)
modules/Ubuntu/Components/plugin/ucstyleditembase.cpp (+2/-4)
modules/Ubuntu/Test/UbuntuTestCase.qml (+3/-6)
tests/qmlapicheck.sh (+1/-1)
tests/resources/listitems/ListItemTest.qml (+201/-0)
tests/unit/tst_performance/ItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemList.qml (+30/-0)
tests/unit/tst_performance/ListItemWithActionsList.qml (+43/-0)
tests/unit/tst_performance/ListItemWithInlineActionsList.qml (+41/-0)
tests/unit/tst_performance/ListItemsBaseList.qml (+29/-0)
tests/unit/tst_performance/ListItemsEmptyList.qml (+29/-0)
tests/unit/tst_performance/tst_performance.cpp (+7/-8)
tests/unit/tst_performance/tst_performance.pro (+7/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+570/-0)
| description: | updated |
| description: | updated |
| tags: | added: listitem |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Triaged |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → High |
| assignee: | nobody → Zsombor Egri (zsombi) |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → High |
| status: | New → Triaged |
| no longer affects: | ubuntu-ui-toolkit |
| Zsombor Egri (zsombi) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Triaged → Invalid |
| status: | Invalid → Fix Committed |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
This is a bit contradicting to the new design, where controls placed in a list item should not toggle or be activated if pressed outside of the control. See https:/
The new ListItem will implement the press/longpress separation more properly, meaning if the user (developer) does not connect any slot to the pressAndHold signal, there click will be emitted. This behaviour matches the one defined by the MouseArea component.