back button should not be random when in shuffle mode
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Media Hub |
Invalid
|
Undecided
|
Unassigned | ||
| Ubuntu Music App |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
When playing in shuffle mode, songs advance in random order (fine). If I press the forward button they also advance in random order (also fine). However, when I press the back button, the next song is also random. This is a usability issue and not how other players work. Consider that I want to hear a song again after it advances-- I cannot simply press 'back' to get to it. Consider if I am pressing forward over and over to find a song I like, and a companion says 'hey, I love that song!' -- I can't go back to it (perhaps this is a feature in this instance ;)
I'm not sure what other players do, but it seems that a simple stack could be implemented for this. When a song advances either through normal playing or pressing the forward button, you push the song onto the stack. When you press the back button, you pop it.
Related branches
- Jenkins Bot: Approve (continuous-integration)
- Victor Thompson: Approve
-
Diff: 2709 lines (+461/-752)30 files modifiedapp/components/BlurredBackground.qml (+2/-2)
app/components/Flickables/MultiSelectListView.qml (+9/-2)
app/components/HeadState/MultiSelectHeadState.qml (+4/-4)
app/components/Helpers/ContentHubHelper.qml (+11/-8)
app/components/Helpers/UriHandlerHelper.qml (+17/-32)
app/components/Helpers/UserMetricsHelper.qml (+10/-7)
app/components/ListItemActions/AddToPlaylist.qml (+6/-2)
app/components/ListItemActions/AddToQueue.qml (+2/-2)
app/components/MusicToolbar.qml (+37/-23)
app/components/NowPlayingFullView.qml (+57/-17)
app/components/NowPlayingToolbar.qml (+18/-30)
app/components/Player.qml (+0/-240)
app/components/Queue.qml (+18/-20)
app/components/ViewButton/PlayAllButton.qml (+6/-2)
app/components/ViewButton/QueueAllButton.qml (+6/-2)
app/components/ViewButton/ShuffleButton.qml (+6/-2)
app/logic/meta-database.js (+14/-4)
app/logic/playlists.js (+9/-2)
app/music-app.qml (+93/-220)
app/ui/AddToPlaylist.qml (+0/-1)
app/ui/ContentHubExport.qml (+8/-17)
app/ui/NowPlaying.qml (+29/-16)
app/ui/Playlists.qml (+0/-1)
app/ui/Recent.qml (+0/-1)
app/ui/Songs.qml (+2/-3)
debian/changelog (+4/-1)
debian/control (+1/-0)
manifest.json.in (+1/-1)
tests/autopilot/music_app/__init__.py (+30/-11)
tests/autopilot/music_app/tests/test_music.py (+61/-79)
| Andrew Hayzen (ahayzen) wrote | #1 |
| Changed in music-app: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu: | |
| status: | New → Confirmed |
| Changed in music-app: | |
| assignee: | nobody → Zhang Boren (bobo-324) |
| Changed in music-app: | |
| status: | Triaged → In Progress |
| Boren Zhang (bobo-324) wrote | #3 |
| Changed in music-app: | |
| assignee: | Zhang Boren (bobo-324) → nobody |
| Changed in music-app: | |
| status: | In Progress → Confirmed |
| Andrew Hayzen (ahayzen) wrote | #4 |
| Changed in media-hub: | |
| status: | New → Invalid |
| Bartosz Kosiorek (gang65) wrote | #5 |
| Changed in media-hub: | |
| status: | Invalid → Confirmed |
| Jim Hodapp (jhodapp) wrote | #6 |
| Changed in media-hub: | |
| status: | Confirmed → Invalid |
| Changed in music-app: | |
| status: | Confirmed → In Progress |
| milestone: | none → ota9 |
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #7 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → Fix Released |
Agreed, the shuffle workflow needs overhauling to actually remember what tracks were played.