ui-toolkit fails some tests against Qt 5.1.1

Bug #1217331 reported by Timo Jyrinki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Zoltan Balogh
qtbase-opensource-src (Ubuntu)
Fix Released
High
Dmitry Shachnev
qtdeclarative-opensource-src (Ubuntu)
Fix Released
High
Dmitry Shachnev

Bug Description

I've been doing rebuilds of a good selection of packages in our daily release system against Qt 5.1.1, and it seems ubuntu-ui-toolkit is failing to build on all archs, or more accurately tests cause a crash: https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+sourcepub/3448597/+listing-archive-extra

So far all other 30+ packages build for armhf at least (http://is.gd/5Calkj + http://is.gd/PuhaYi) so the issue is ui-toolkit specific.

If you need to do something Qt 5.1 specific, see eg. https://code.launchpad.net/~aacid/unity8/supportqt51/+merge/177365 on how to #ifdef on the Qt version to support both 5.0.x and 5.1.x.

To reproduce:
sudo apt-add-repository ppa:canonical-qt5-edgers/qt5-beta-proper
sudo apt-get update
sudo apt-get dist-upgrade
+ build

To revert back to archive versions:

sudo ppa-purge ppa:canonical-qt5-edgers/qt5-beta-proper

Tags: qt5.1 qt5.2
tags: added: qt5.1
description: updated
description: updated
description: updated
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I think this is the highest priority fix, followed by OSK & QPA bugs, related to 5.1.1 issues.

Changed in ubuntu-ui-toolkit:
importance: Undecided → Critical
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
assignee: nobody → Zsombor Egri (zsombi)
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
assignee: Zsombor Egri (zsombi) → Zoltan Balogh (bzoltan)
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
status: New → In Progress
description: updated
summary: - ui-toolkit fails to build against Qt 5.1.1
+ ui-toolkit fails some tests against Qt 5.1.1
description: updated
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

When I try to build it with DEB_BUILD_OPTIONS=nocheck, I get another crash in qdoc code, reported as https://bugreports.qt-project.org/browse/QTBUG-33387.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

With two of the linked branches the package now builds with DEB_BUILD_OPTIONS=nocheck. The third branch (the qtdeclarative one) fixes the segfault in tests. Some tests still fail, however, I hope that some ubuntu-ui-toolkit devs can look at that.

Changed in qtbase-opensource-src (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Dmitry Shachnev (mitya57)
Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Dmitry Shachnev (mitya57)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I'm building updated qtbase and qtdeclarative with mitya57's much appreciated patches at https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+packages and copying them over to qt5-beta-proper once ready and I've smoketested them on device.

The remaining problems probably need to be fixed inside ubuntu-ui-toolkit like Dmitry mentioned.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The remaining problems are all in tst_Layouts. If I comment that out, tests finish successfully (docs building needs mitya57's branch merged).

The tst_Layouts have Totals: 13 passed, 18 failed, 0 skipped

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Download full text (6.1 KiB)

---
********* Start testing of tst_Layouts *********
Config: Using QtTest library 5.1.1, Qt 5.1.1
PASS : tst_Layouts::initTestCase()
PASS : tst_Layouts::testCase_NoLayouts()
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
QWARN : tst_Layouts::testCase_SimpleLayout() QFontDatabase: Cannot find font directory '/usr/lib/x86_64-linux-gnu/fonts' - is Qt installed correctly?
FAIL! : tst_Layouts::testCase_SimpleLayout() 'item->parentItem()->parentItem()->inherits("QQuickColumn")' returned FALSE. ()
   Loc: [tst_layouts.cpp(124)]
FAIL! : tst_Layouts::testCase_SimpleLayout_Medium() 'item->parentItem()->parentItem()->inherits("QQuickFlow")' returned FALSE. ()
   Loc: [tst_layouts.cpp(151)]
FAIL! : tst_Layouts::testCase_SimpleLayout_Large() 'item->parentItem()->parentItem()->inherits("QQuickRow")' returned FALSE. ()
   Loc: [tst_layouts.cpp(178)]
PASS : tst_Layouts::testCase_OverlappingCondition()
PASS : tst_Layouts::testCase_ExternalLayouts()
PASS : tst_Layouts::testCase_ExternalLayouts_Medium()
PASS : tst_Layouts::testCase_ExternalLayouts_Large()
PASS : tst_Layouts::testCase_NestedLayouts()
FAIL! : tst_Layouts::testCase_NestedLayouts_ExtraLarge() Compared values are not the same
   Actual (root->property("nestedLayout").toString()):
   Expected (QString("medium")): medium
   Loc: [tst_layouts.cpp(267)]
FAIL! : tst_Layouts::testCase_ResizingContainers() Compared doubles are not the same (fuzzy compare)
   Actual (item->width()): 400
   Expected (UCUnits::instance().gu(10)): 80
   Loc: [tst_layouts.cpp(290)]
QWARN : tst_Layouts::testCase_CurrentLayoutChange() file:///home/bigfiles/qt5/com/build-area/ubuntu-ui-toolkit-0.1.46+13.10.20130903.4/tests/unit/tst_layouts/CurrentLayoutChange.qml:30:13: QML ConditionalLayout: ERROR: no container specified for layout "portrait". ConditionalLayout cannot be activated without a container.
QWARN : tst_Layouts::testCase_CurrentLayoutChange() file:///home/bigfiles/qt5/com/build-area/ubuntu-ui-toolkit-0.1.46+13.10.20130903.4/tests/unit/tst_layouts/CurrentLayoutChange.qml:35:13: QML ConditionalLayout: ERROR: no container specified for layout "landscape". ConditionalLayout cannot be activated without a container.
QWARN : tst_Layouts::testCase_CurrentLayoutChange() file:///home/bigfiles/qt5/com/build-area/ubuntu-ui-toolkit-0.1.46+13.10.20130903.4/tests/unit/tst_layouts/CurrentLayoutChange.qml:30:13: QML ConditionalLayout: WARNING: Cannot activate layout "portrait" with no container specified. Falling b...

Read more...

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

lower importance given 5.1 will be deferred

Changed in ubuntu-ui-toolkit:
importance: Critical → High
tags: added: qt5.2
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Continued in bug #1256235 for Qt 5.2.

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (13.3 KiB)

This bug was fixed in the package qtbase-opensource-src - 5.2.1+dfsg-1ubuntu7

---------------
qtbase-opensource-src (5.2.1+dfsg-1ubuntu7) trusty; urgency=medium

  [ Colin Watson ]
  * Add arm64 to archs that don't use -m64

qtbase-opensource-src (5.2.1+dfsg-1ubuntu6) trusty; urgency=medium

  * Add Use-None-instead-of-GLX_NONE.patch:
    - Cherry-pick upstream patch (LP: #1288278)

qtbase-opensource-src (5.2.1+dfsg-1ubuntu5) trusty; urgency=medium

  * Only run tests on armhf, amd64 and i386.

qtbase-opensource-src (5.2.1+dfsg-1ubuntu4) trusty; urgency=medium

  [ Chris Gagnon ]
  * Enable unit tests

qtbase-opensource-src (5.2.1+dfsg-1ubuntu3) trusty; urgency=medium

  * Revert the transitional package change final landing.

qtbase-opensource-src (5.2.1+dfsg-1ubuntu2) trusty; urgency=medium

  * libqt5core5 transitional package to be able to run ABI related tests

qtbase-opensource-src (5.2.1+dfsg-1ubuntu1) trusty; urgency=low

  [ Dmitry Shachnev ]
  * Update watch file (taken from Debian).
  * Fix generating documentation by building qdoc before using it.
  * Remove qtcreator.qdoc from qtbase5-doc.install, as it is already in
    qtbase5-dev.install.
  * Merge with Debian up to 5.2.0~beta1+dfsg-3.
    - Fixes build failures on powerpc and armel.
  * Add debian/patches/fix_cppcodemarker_crash.patch to fix qdoc
    crash that caused ubuntu-ui-toolkit to FTBFS (LP: #1217331).

  [ Łukasz 'sil2100' Zemczak ]
  * Cherry-pick two submitted patches to support appmenu-qt: (LP: #1157213)
    - make_qkdetheme_constructor_public.diff
    - platformtheme_env.diff

  [ Timo Jyrinki ]
  * New upstream release 5.2.1 (LP: #1256341) (LP: #1223032) (LP: #1222988)
    (LP: #1223042) (LP: #1253120) (LP: #1251262)
  * Sync with Debian 5.2.0+dfsg-7, remaining changes:
    - Remove firebird and ibase dependencies
    - Maintainer fields and Vcs-Bzr
    - No gdb required on ppc64el
    - Provides: qt-default to qt5-default
    - Define explicit list on which archs openvg required
    - Additional patches:
      + disable_overlay_scrollbars.diff
      + load_testability_from_env_var.patch
      + make_qkdetheme_constructor_public.diff
      + platformtheme_env.diff
      + qdoc-Fix-crash-in-Generator-generateInnerNode.patch
      + 0001-Do-not-overwrite-basePixmap-of-QIconLoader-PixmapEnt.patch
    - Use our symbols files
    - Additional multi-arch packages (not correct policy-wise)
  * Drop upstream patches:
    - add_since_52_to_new_QColor_features.patch
    - fix_cppcodemarker_crash.patch
    - fix_usr-move_workaround_in_the_presence_of_multi-arch.patch
    - make_QColor_understand_AARRGGBB.patch
    - Add-workaround-for-GL-on-Android-emulator.patch
    - 0001-Do-not-overwrite-basePixmap-of-QIconLoader-PixmapEnt.patch
    - fix_destroy_qapp_segfault.diff
  * Remove Ubuntu patches:
    - enable_appmenu_support.diff (obsolete)
    - 0001-Implement-XEmbed-protocol.patch (submitted and merged upstream)
    - fix_maliit_activation.patch (not used anymore)
    - inputmethod_fix_focusout.patch (not used anymore)
    - fix_number_precision_qjsondocument.patch_8e8becdc.patch (upstream)
    - bug1227629.patch (merged upstream)
    - fix_rowinserted.patch (LP: #1242630...

Changed in qtbase-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
Changed in qtdeclarative-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.