Dialog integration
Bug #1214035 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
Implement an API to allow embedders to hook in their own dialog implementations for things like alert() and confirm()
Related branches
lp:~osomon/oxide/js-dialogs
- Chris Coulson: Approve
-
Diff: 2167 lines (+1804/-0)38 files modifiedqt/core/browser/oxide_qt_javascript_dialog.cc (+66/-0)
qt/core/browser/oxide_qt_javascript_dialog.h (+57/-0)
qt/core/core.gyp (+4/-0)
qt/core/glue/oxide_qt_javascript_dialog_delegate.cc (+60/-0)
qt/core/glue/oxide_qt_javascript_dialog_delegate.h (+61/-0)
qt/core/glue/oxide_qt_web_view_adapter.h (+4/-0)
qt/core/glue/private/oxide_qt_web_view_adapter_p.cc (+29/-0)
qt/core/glue/private/oxide_qt_web_view_adapter_p.h (+6/-0)
qt/quick/CMakeLists.txt (+5/-0)
qt/quick/api/oxideqquickwebview.cc (+101/-0)
qt/quick/api/oxideqquickwebview_p.h (+21/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+7/-0)
qt/quick/oxide_qquick_alert_dialog_delegate.cc (+65/-0)
qt/quick/oxide_qquick_alert_dialog_delegate.h (+41/-0)
qt/quick/oxide_qquick_before_unload_dialog_delegate.cc (+73/-0)
qt/quick/oxide_qquick_before_unload_dialog_delegate.h (+42/-0)
qt/quick/oxide_qquick_confirm_dialog_delegate.cc (+70/-0)
qt/quick/oxide_qquick_confirm_dialog_delegate.h (+41/-0)
qt/quick/oxide_qquick_javascript_dialog_delegate.cc (+67/-0)
qt/quick/oxide_qquick_javascript_dialog_delegate.h (+54/-0)
qt/quick/oxide_qquick_prompt_dialog_delegate.cc (+109/-0)
qt/quick/oxide_qquick_prompt_dialog_delegate.h (+42/-0)
qt/tests/qmltests/api/tst_WebView_alertDialog.html (+7/-0)
qt/tests/qmltests/api/tst_WebView_alertDialog.qml (+68/-0)
qt/tests/qmltests/api/tst_WebView_beforeUnloadDialog.html (+22/-0)
qt/tests/qmltests/api/tst_WebView_beforeUnloadDialog.qml (+92/-0)
qt/tests/qmltests/api/tst_WebView_beforeUnloadDialog2.html (+4/-0)
qt/tests/qmltests/api/tst_WebView_confirmDialog.html (+12/-0)
qt/tests/qmltests/api/tst_WebView_confirmDialog.qml (+90/-0)
qt/tests/qmltests/api/tst_WebView_promptDialog.html (+16/-0)
qt/tests/qmltests/api/tst_WebView_promptDialog.qml (+105/-0)
shared/browser/oxide_javascript_dialog.cc (+44/-0)
shared/browser/oxide_javascript_dialog.h (+54/-0)
shared/browser/oxide_javascript_dialog_manager.cc (+161/-0)
shared/browser/oxide_javascript_dialog_manager.h (+76/-0)
shared/browser/oxide_web_view.cc (+15/-0)
shared/browser/oxide_web_view.h (+9/-0)
shared/shared.gyp (+4/-0)
Changed in oxide: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in oxide: | |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in oxide: | |
status: | Triaged → In Progress |
tags: | added: desktop webapp-container |
tags: | added: webapps-blocker |
Changed in oxide: | |
status: | In Progress → Fix Committed |
Changed in oxide: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.