python-mode.el

Non-indenting colon

Bug #1207405 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-mode.el
Fix Released
Medium
Andreas Roehler
python-mode.el 6.1.2 "Capybara"

Bug Description

def foo(bar):
    for i in range(10):
        print(i)
    tied = bar[

Put point on the last line, after the open bracket. Hit colon (as if you were going to type bar[:]). The line gets incorrectly indented to under the `print`.

There may be other situations where colons should not re-indent the line.

Andreas Roehler (a-roehler)
Changed in python-mode:
assignee: nobody → Andreas Roehler (a-roehler)
milestone: none → 6.1.2
importance: Undecided → Medium
Revision history for this message
Andreas Roehler (a-roehler) wrote :

Hmm, AFAIU `print' does not close the `for'-loop, so such assignment seems possible at that place(?) Electric-colon always will choose the rightmost thinkable.

Will provide a menu toggling `py-electric-colon-active-p' in any case.

Andreas

Changed in python-mode:
status: New → In Progress
Revision history for this message
Barry Warsaw (barry) wrote : Re: [Bug 1207405] Re: Non-indenting colon

On Aug 07, 2013, at 06:59 PM, Andreas Roehler wrote:

>Hmm, AFAIU `print' does not close the `for'-loop, so such assignment
>seems possible at that place(?)

Correct, but that's not the point.

>Electric-colon always will choose the rightmost thinkable.
>
>Will provide a menu toggling `py-electric-colon-active-p' in any case.

The point is that not all colons are "indenting colons". In this case, the
colon doesn't introduce a new stanza, it separates indexes in a slice, so I
don't think it should change the indentation of the line regardless of the
value of py-e-c-a-p. Toggling that variable isn't helpful because you usually
want electric colons, but only for those which have stanza-opening semantics.

Revision history for this message
Andreas Roehler (a-roehler) wrote :

Am 12.08.2013 16:43, schrieb Barry Warsaw:
> On Aug 07, 2013, at 06:59 PM, Andreas Roehler wrote:
>
>> Hmm, AFAIU `print' does not close the `for'-loop, so such assignment
>> seems possible at that place(?)
>
> Correct, but that's not the point.
>
>> Electric-colon always will choose the rightmost thinkable.
>>
>> Will provide a menu toggling `py-electric-colon-active-p' in any case.
>
> The point is that not all colons are "indenting colons". In this case, the
> colon doesn't introduce a new stanza,

Okay, may implement that rule:

electric indent colon only when opening a block.

Andreas Roehler (a-roehler)
Changed in python-mode:
status: In Progress → Fix Committed
Andreas Roehler (a-roehler)
Changed in python-mode:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.