power-management/hibernate_30_cycles didn't generate log file

Bug #1186870 reported by Jeffrey Chang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Low
Daniel Manrique

Bug Description

Checkbox 0.16.2~ppa+bzr1969+201305171006~precise1

The test power-management/hibernate_30_cycles does not generate test log if calling sleep_test.
It should put all output to $CHECKBOX_DATA/hibernate_30_cycles.log, but not.
Thus makes following log check and log attach case totally useless.
power-management/hibernate-30-cycles-log-check & power-management/hibernate-30-cycle-log-attach

Same issue also apply to stress/hibernate_250_cycles.

Related branches

description: updated
Revision history for this message
Daniel Manrique (roadmr) wrote :

For the record, the best way to get the desired behavior is by installing fwts before running checkbox, we recommend this as fwts does more thorough testing and diagnostics.

That said, we did find an oversight in how the log file is generated. The sleep 30 cycles test has this in the part where it invokes sleep_test, in absence of fwts:

set -o pipefail; sleep_test -p s mem -i 30 | tee $CHECKBOX_DATA/suspend_30_cycles_times.log

However, hibernate 30 cycles has only this:

sleep_test -s disk -i 30 -w 120

The same thing happens with the 250-cycle variants. I'll propose a fix for this in a moment.

Changed in checkbox:
status: New → In Progress
assignee: nobody → Daniel Manrique (roadmr)
importance: Undecided → High
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi Jeffrey,

After discussing with Jeff Lane, we agreed that it's recommended to use fwts for these tests, so that the attachments you need are generated and added to the submission. sleep_test was mainly created as a fallback in case a user can't install fwts for some reason.

In any case, I fixed the inconsistencies we found in this merge request:

https://code.launchpad.net/~roadmr/checkbox/no-log-in-stress-suspend/+merge/167142

I didn't officially link it to the bug because this isn't a proper fix, just linking it here for reference.

The proper status for this bug is "Won't Fix" but I dislike using that because it's ugly, so I won't set it until I get confirmation from you, that things work as expected with fwts and that solution is satisfactory. If you prefer to solve this another way, let me know and we can discuss it. I'll set to "incomplete" for now.

Changed in checkbox:
status: In Progress → Incomplete
importance: High → Low
Revision history for this message
Daniel Manrique (roadmr) wrote :

Er, actually the proposed fix will work here because it creates the proper log file names to be attached, but I still suggest using fwts which produces better logs.

Revision history for this message
Jeffrey Chang (modern911) wrote :

I also believe fwts is the best way to run these test.
Actually, I heard some problem about not generating test log from hibernate test.
This issue is the result after reviewing our job file.
Please propose a fix, and we will keep watching if we see problem later.
Thanks

Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, I linked the bug to the proposed fix, it should make it into the next checkbox release.

I also set to Fix Committed as the linked fix does take care of this problem.

Thanks!

Changed in checkbox:
status: Incomplete → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.